Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11385

cordova-plugin-file Android does not pass sonarqube scan

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Master
    • Master
    • cordova-plugin-file
    • None
    • Android

    Description

      The Android file plugin does not pass sonarqube (http://www.sonarqube.org/) scan.

      The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major:
      Preserve stack trace,
      Reliance on default encoding,

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user rob-close opened a pull request:

            https://github.com/apache/cordova-plugin-file/pull/183

            CB-11385 android: Does not pass sonarqube scan

            The problem are "Empty Catch Block", which sonarqube considers a blocker, and the
            following, which sonarqube considers major:
            Preserve stack trace, Reliance on default encoding.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/rob-close/cordova-plugin-file master

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-file/pull/183.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #183


            commit c10a71acf1ccd9d61c9e465f91587dd020238edb
            Author: Rob Close <rob.close@sap.com>
            Date: 2016-06-07T17:15:26Z

            CB-11385 android: Does not pass sonarqube scan

            The problem are "Empty Catch Block", which sonarqube considers a blocker, and the
            following, which sonarqube considers major:
            Preserve stack trace, Reliance on default encoding.


            githubbot ASF GitHub Bot added a comment - GitHub user rob-close opened a pull request: https://github.com/apache/cordova-plugin-file/pull/183 CB-11385 android: Does not pass sonarqube scan The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major: Preserve stack trace, Reliance on default encoding. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rob-close/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit c10a71acf1ccd9d61c9e465f91587dd020238edb Author: Rob Close <rob.close@sap.com> Date: 2016-06-07T17:15:26Z CB-11385 android: Does not pass sonarqube scan The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major: Preserve stack trace, Reliance on default encoding.
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-file/pull/183

            Cordova CI Build has completed successfully.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-file/pull/183/commits/master)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/artifact/)
            [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/183 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-file/pull/183/commits/master ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=windows-slave,platformName=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=ios/artifact/ ) [Android Mac] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/17//label=mac-slave,platformName=android/artifact/ )

            Commit 4270ae23b5ac9af9e3c9c18b6339d5bf9d0a6396 in cordova-plugin-file's branch refs/heads/master from rclose
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=4270ae2 ]

            CB-11385 android: Does not pass sonarqube scan

            The problem are "Empty Catch Block", which sonarqube considers a blocker, and the
            following, which sonarqube considers major:
            Preserve stack trace, Reliance on default encoding.

            This closes #183

            jira-bot ASF subversion and git services added a comment - Commit 4270ae23b5ac9af9e3c9c18b6339d5bf9d0a6396 in cordova-plugin-file's branch refs/heads/master from rclose [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=4270ae2 ] CB-11385 android: Does not pass sonarqube scan The problem are "Empty Catch Block", which sonarqube considers a blocker, and the following, which sonarqube considers major: Preserve stack trace, Reliance on default encoding. This closes #183
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-file/pull/183

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/183

            Commit a309a3d53be278efe8253b84af84a3b5ee38fc20 in cordova-plugin-file's branch refs/heads/master from Mateus Nava
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=a309a3d ]

            CB-11385 android: Import java.nio.charset.Charset in LocalFileSystem class

            This closes #185

            jira-bot ASF subversion and git services added a comment - Commit a309a3d53be278efe8253b84af84a3b5ee38fc20 in cordova-plugin-file's branch refs/heads/master from Mateus Nava [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=a309a3d ] CB-11385 android: Import java.nio.charset.Charset in LocalFileSystem class This closes #185

            People

              Unassigned Unassigned
              rclose Rob Close
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: