Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11381

cordova-plugin-inappbrowser Android does not pass sonarqube scan

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Master
    • Master
    • None
    • Android

    Description

      The Android inappbrowser plugin does not pass sonarqube (http://www.sonarqube.org/) scan.

      The problem is "Empty Catch Block", which sonarqube considers a blocker.

      Attachments

        Issue Links

          Activity

            iroh Chris Wells made changes -
            Workflow Classic - editable closed [ 14066482 ] classic default workflow [ 14079361 ]
            iroh Chris Wells made changes -
            Workflow classic default workflow [ 13185856 ] Classic - editable closed [ 14066482 ]
            shazron Shazron Abdullah made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            nikhilkh Nikhil Khandelwal made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/169

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/169
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ] This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ]

            Commit bcdc0b9da01862dacac554db5fd6836d6463c4cc in cordova-plugin-inappbrowser's branch refs/heads/master from rclose
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=bcdc0b9 ]

            CB-11381 android: Does not pass sonarqube scan

            The problem is "Empty Catch Block", which sonarqube considers a blocker. Added
            a log message to the empty block.

            This closes #169

            jira-bot ASF subversion and git services added a comment - Commit bcdc0b9da01862dacac554db5fd6836d6463c4cc in cordova-plugin-inappbrowser's branch refs/heads/master from rclose [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=bcdc0b9 ] CB-11381 android: Does not pass sonarqube scan The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block. This closes #169
            githubbot ASF GitHub Bot added a comment -

            Github user jcesarmobile commented on the issue:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/169

            LGTM

            githubbot ASF GitHub Bot added a comment - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 LGTM
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ] This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ]
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/169

            Cordova CI Build has completed successfully.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/169/commits/master)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/artifact/)
            [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-inappbrowser/pull/169/commits/master ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=windows-slave,platformName=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=ios/artifact/ ) [Android Mac] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/13//label=mac-slave,platformName=android/artifact/ )
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ] This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ]
            githubbot ASF GitHub Bot added a comment -

            GitHub user rob-close opened a pull request:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/169

            CB-11381 android: Does not pass sonarqube scan

            The problem is "Empty Catch Block", which sonarqube considers a blocker. Added
            a log message to the empty block.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/rob-close/cordova-plugin-inappbrowser master

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-inappbrowser/pull/169.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #169


            commit 808f3d061a1138669116634d9fb7ae0d4d09fbac
            Author: Rob Close <rob.close@sap.com>
            Date: 2016-06-06T18:13:21Z

            CB-11381 android: Does not pass sonarqube scan

            The problem is "Empty Catch Block", which sonarqube considers a blocker. Added
            a log message to the empty block.


            githubbot ASF GitHub Bot added a comment - GitHub user rob-close opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 CB-11381 android: Does not pass sonarqube scan The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rob-close/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 808f3d061a1138669116634d9fb7ae0d4d09fbac Author: Rob Close <rob.close@sap.com> Date: 2016-06-06T18:13:21Z CB-11381 android: Does not pass sonarqube scan The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block.
            githubbot ASF GitHub Bot made changes -
            Remote Link This issue links to "GitHub Pull Request #169 (Web Link)" [ 44341 ]
            rclose Rob Close made changes -
            Description The Android inappbrowser plugin does not pass sonarqube (http://www.sonarqube.org/) scan The Android inappbrowser plugin does not pass sonarqube (http://www.sonarqube.org/) scan.

            The problem is "Empty Catch Block", which sonarqube considers a blocker.
            rclose Rob Close made changes -
            Field Original Value New Value
            Component/s Plugin InAppBrowser [ 12320641 ]
            Component/s Android [ 12316401 ]
            rclose Rob Close created issue -

            People

              Unassigned Unassigned
              rclose Rob Close
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: