Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11380

Media Plugin - IOS: Error when creating Media object with new file

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.3.0
    • None
    • cordova-plugin-media
    • iOS 9.3.1

    Description

      The line:

      var myMedia = new Media("documents://hello.wav",
         function() {
              console.log("success");
         },
         function(er) {
              console.log(er);
         }
      );
      

      results in the error "Cannot use audio file from resource 'documents:hello.wav'", when "hello.wav" does not exist. The created Media object is usable (I can record and play back), but the error means the constructor's success callback never gets called. Also happens with variations of the src URI using "file" and "cdvfile".

      This is caused by a change to the validation parameter from NO to YES in commit e5b663ac951b2d8cb2e5e470d2c7072aa56cf779 on March 2nd.

      Attachments

        Activity

          Unfortunately I haven't been able to reproduce this issue neither on iPhone 6 Plus with iOS 9.3.1 nor on iPad 2 with iOS 8.1

          jkeating can you please use the plugin from master branch here: https://github.com/apache/cordova-plugin-media/ and tell us if the issue persists?

          alsorokin Alexander Sorokin added a comment - Unfortunately I haven't been able to reproduce this issue neither on iPhone 6 Plus with iOS 9.3.1 nor on iPad 2 with iOS 8.1 jkeating can you please use the plugin from master branch here: https://github.com/apache/cordova-plugin-media/ and tell us if the issue persists?

          UPD: Nevermind, I've got the repro.

          alsorokin Alexander Sorokin added a comment - UPD: Nevermind, I've got the repro.
          githubbot ASF GitHub Bot added a comment -

          GitHub user alsorokin opened a pull request:

          https://github.com/apache/cordova-plugin-media/pull/112

          CB-11380 (ios) Fixed an unexpected error callback when initializing M…

              1. Platforms affected
                iOS
              1. What does this PR do?
                Eliminates an unexpected error callback when initializing Media with the file that doesn't exist:
                https://issues.apache.org/jira/browse/CB-11380
              1. What testing has been done on this change?
                Tested manually on iOS 8.1
              1. Checklist

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-media/pull/112.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #112


          commit 0b4c67e524ee7d4b411d4527bb9347442cd8ea16
          Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
          Date: 2016-08-25T11:21:41Z

          CB-11380 (ios) Fixed an unexpected error callback when initializing Media with file that doesn't exist


          githubbot ASF GitHub Bot added a comment - GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/112 CB-11380 (ios) Fixed an unexpected error callback when initializing M… Platforms affected iOS What does this PR do? Eliminates an unexpected error callback when initializing Media with the file that doesn't exist: https://issues.apache.org/jira/browse/CB-11380 What testing has been done on this change? Tested manually on iOS 8.1 Checklist [x] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #112 commit 0b4c67e524ee7d4b411d4527bb9347442cd8ea16 Author: Alexander Sorokin <alexander.sorokin@akvelon.com> Date: 2016-08-25T11:21:41Z CB-11380 (ios) Fixed an unexpected error callback when initializing Media with file that doesn't exist
          githubbot ASF GitHub Bot added a comment -

          Github user alsorokin commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/112

          @shazron could you please help review this?

          This fixes a regression caused by https://github.com/apache/cordova-plugin-media/pull/85

          githubbot ASF GitHub Bot added a comment - Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 @shazron could you please help review this? This fixes a regression caused by https://github.com/apache/cordova-plugin-media/pull/85
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/112

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/112/commits/0b4c67e524ee7d4b411d4527bb9347442cd8ea16)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/artifact/)
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/artifact/)
          [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/artifact/)
          [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/artifact/)
          [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/artifact/)
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/112/commits/0b4c67e524ee7d4b411d4527bb9347442cd8ea16 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/68//PLATFORM=android/artifact/ )
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/112

          LGTM đź‘Ť

          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 LGTM đź‘Ť
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/112

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/112/commits/910d3c798f77c63165be508125ec313e4104b541)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/artifact/)
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/artifact/)
          [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/artifact/)
          [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/artifact/)
          [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/artifact/)
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/112 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/112/commits/910d3c798f77c63165be508125ec313e4104b541 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/71//PLATFORM=android/artifact/ )

          Commit 910d3c798f77c63165be508125ec313e4104b541 in cordova-plugin-media's branch refs/heads/master from alsorokin
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=910d3c7 ]

          CB-11380 (ios) Fixed an unexpected error callback when initializing Media with file that doesn't exist

          jira-bot ASF subversion and git services added a comment - Commit 910d3c798f77c63165be508125ec313e4104b541 in cordova-plugin-media's branch refs/heads/master from alsorokin [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=910d3c7 ] CB-11380 (ios) Fixed an unexpected error callback when initializing Media with file that doesn't exist
          githubbot ASF GitHub Bot added a comment -

          Github user alsorokin closed the pull request at:

          https://github.com/apache/cordova-plugin-media/pull/112

          githubbot ASF GitHub Bot added a comment - Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/112

          Commit 42b279b911c4b20689290f55ecb849905d3f1673 in cordova-plugin-media's branch refs/heads/master from alsorokin
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=42b279b ]

          CB-11380 (ios) Updated modified method signature in the .h file

          jira-bot ASF subversion and git services added a comment - Commit 42b279b911c4b20689290f55ecb849905d3f1673 in cordova-plugin-media's branch refs/heads/master from alsorokin [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=42b279b ] CB-11380 (ios) Updated modified method signature in the .h file
          githubbot ASF GitHub Bot added a comment -

          GitHub user alsorokin opened a pull request:

          https://github.com/apache/cordova-plugin-media/pull/114

          CB-11380 (ios) Overloaded audioFileForResource method instead of modi…

              1. Platforms affected
                ios
              1. What does this PR do?
                https://issues.apache.org/jira/browse/CB-11380
                Overloads the audioFileForResource method instead of modifying its signature because otherwise it would be an API breakage.
              1. What testing has been done on this change?
                No testing whatsoever: I don't have an access to any iOS device till tomorrow. Creating this PR to let CI test the changes.
              1. Checklist

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugin-media/pull/114.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #114


          commit 9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09
          Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
          Date: 2016-08-26T18:41:51Z

          CB-11380 (ios) Overloaded audioFileForResource method instead of modifying its signature


          githubbot ASF GitHub Bot added a comment - GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/114 CB-11380 (ios) Overloaded audioFileForResource method instead of modi… Platforms affected ios What does this PR do? https://issues.apache.org/jira/browse/CB-11380 Overloads the audioFileForResource method instead of modifying its signature because otherwise it would be an API breakage. What testing has been done on this change? No testing whatsoever: I don't have an access to any iOS device till tomorrow. Creating this PR to let CI test the changes. Checklist [x] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #114 commit 9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09 Author: Alexander Sorokin <alexander.sorokin@akvelon.com> Date: 2016-08-26T18:41:51Z CB-11380 (ios) Overloaded audioFileForResource method instead of modifying its signature
          githubbot ASF GitHub Bot added a comment -

          Github user cordova-qa commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/114

          Cordova CI Build has completed successfully.

          *Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/114/commits/9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09)
          *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75/)

          Builder Name Console Output Test Report Device Logs
          :---: :---: :---: :---:
          [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/artifact/)
          [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/artifact/)
          [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/artifact/)
          [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/artifact/)
          [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/artifact/)
          githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-media/pull/114/commits/9f0c2e3e6bc1d76dcb0759f2aaf9e4137e391b09 ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/75//PLATFORM=android/artifact/ )
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/114

          LGTM đź‘Ť
          Tested locally.

          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 LGTM đź‘Ť Tested locally.
          githubbot ASF GitHub Bot added a comment -

          Github user alsorokin commented on the issue:

          https://github.com/apache/cordova-plugin-media/pull/114

          Thanks Shazron!

          githubbot ASF GitHub Bot added a comment - Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/114 Thanks Shazron!

          Commit 0405a2ee2bfc7520e121e50483b2b5310e5e66bd in cordova-plugin-media's branch refs/heads/master from alsorokin
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=0405a2e ]

          CB-11380 (ios) Overloaded audioFileForResource method instead of modifying its signature

          jira-bot ASF subversion and git services added a comment - Commit 0405a2ee2bfc7520e121e50483b2b5310e5e66bd in cordova-plugin-media's branch refs/heads/master from alsorokin [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=0405a2e ] CB-11380 (ios) Overloaded audioFileForResource method instead of modifying its signature
          githubbot ASF GitHub Bot added a comment -

          Github user alsorokin closed the pull request at:

          https://github.com/apache/cordova-plugin-media/pull/114

          githubbot ASF GitHub Bot added a comment - Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/114

          People

            alsorokin Alexander Sorokin
            jkeating John Keating
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: