Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11368

resolveLocalFileSystemURL cannot handle url returned by contacts plugin

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • cordova-plugin-file

    Description

      navigator.contacts.pickContact returns photo url like content://com.android.contacts/contacts/1/photo, which cannot be resolved by resolveLocalFileSystemURL with FileError code: 1000. I inspect code in the ContentFileSystem.java, and find the method resourceSizeForCursor cannot return correct value. The problem is, that cursor doesn't have a column named _size. I have given permission of File and Contacts.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user matrosovN opened a pull request:

            https://github.com/apache/cordova-plugin-file/pull/192

            CB-11368 android: Resolve content URLs produced by contacts plugin

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                  Android
                1. What does this PR do?
                  This PR does a safe assigment of returning value from resourceSizeForCursor to variable 'size'.
                1. What testing has been done on this change?
                  Manual testing
                1. Checklist

            This bug was happening because of invalid assignment of null value to variable of primitive type

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11368

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-file/pull/192.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #192


            commit 0bc9f912718b353bbac427ea3c614f32a104e28a
            Author: Nikita Matrosov <matrosov.nikita94@gmail.com>
            Date: 2016-08-22T17:11:24Z

            CB-11368 android: Resolve content URLs produced by contacts plugin

            This bug was happening because of invalid assignment of null value to variable of primitive type


            githubbot ASF GitHub Bot added a comment - GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-plugin-file/pull/192 CB-11368 android: Resolve content URLs produced by contacts plugin <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected Android What does this PR do? This PR does a safe assigment of returning value from resourceSizeForCursor to variable 'size'. What testing has been done on this change? Manual testing Checklist [x] [ICLA] ( http://www.apache.org/licenses/icla.txt ) has been signed and submitted to secretary@apache.org. [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. This bug was happening because of invalid assignment of null value to variable of primitive type You can merge this pull request into a Git repository by running: $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11368 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 0bc9f912718b353bbac427ea3c614f32a104e28a Author: Nikita Matrosov <matrosov.nikita94@gmail.com> Date: 2016-08-22T17:11:24Z CB-11368 android: Resolve content URLs produced by contacts plugin This bug was happening because of invalid assignment of null value to variable of primitive type
            githubbot ASF GitHub Bot added a comment -

            Github user cordova-qa commented on the issue:

            https://github.com/apache/cordova-plugin-file/pull/192

            Cordova CI Build has completed successfully.

            *Commit* - [Link](https://github.com/apache/cordova-plugin-file/pull/192/commits/0bc9f912718b353bbac427ea3c614f32a104e28a)
            *Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39/)

            Builder Name Console Output Test Report Device Logs
            :---: :---: :---: :---:
            [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/artifact/)
            [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/artifact/)
            [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/artifact/)
            [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/artifact/)
            [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/console) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/testReport/) [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/artifact/)
            githubbot ASF GitHub Bot added a comment - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/192 Cordova CI Build has completed successfully. * Commit * - [Link] ( https://github.com/apache/cordova-plugin-file/pull/192/commits/0bc9f912718b353bbac427ea3c614f32a104e28a ) * Dashboard * - [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39/ ) Builder Name Console Output Test Report Device Logs :---: :---: :---: :---: [Windows 8.1 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-store/artifact/ ) [Windows 10 Store] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-10-store/artifact/ ) [Windows 8.1 Phone] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=windows-8.1-phone/artifact/ ) [iOS] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=ios/artifact/ ) [Android] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/console ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/testReport/ ) [Link] ( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/39//PLATFORM=android/artifact/ )
            githubbot ASF GitHub Bot added a comment -

            Github user vladimir-kotikov commented on the issue:

            https://github.com/apache/cordova-plugin-file/pull/192

            LGTM

            githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file/pull/192 LGTM

            Commit 9860bbb8567a7ab8994996a3a66313510a05f64a in cordova-plugin-file's branch refs/heads/master from Nikita Matrosov
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=9860bbb ]

            CB-11368 android: Resolve content URLs produced by contacts plugin

            This bug was happening because of invalid assignment of null value to variable of primitive type

            This closes #192

            jira-bot ASF subversion and git services added a comment - Commit 9860bbb8567a7ab8994996a3a66313510a05f64a in cordova-plugin-file's branch refs/heads/master from Nikita Matrosov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=9860bbb ] CB-11368 android: Resolve content URLs produced by contacts plugin This bug was happening because of invalid assignment of null value to variable of primitive type This closes #192
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-file/pull/192

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/192

            People

              Unassigned Unassigned
              zyf0330 zhuisui
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: