Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-lib
    • Labels:

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/cordova-cli/pull/256

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/256
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 486bdab5c0a5f21de48ec989e76984663f561de9 in cordova-cli's branch refs/heads/master from Caryn Tran
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=486bdab ]

        CB-11349 passing --fetch to create

        This closes #256

        Show
        jira-bot ASF subversion and git services added a comment - Commit 486bdab5c0a5f21de48ec989e76984663f561de9 in cordova-cli's branch refs/heads/master from Caryn Tran [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=486bdab ] CB-11349 passing --fetch to create This closes #256
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user stevengill commented on the issue:

        https://github.com/apache/cordova-cli/pull/256

        @carynbear looks like you have a failing test!

        Show
        githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/256 @carynbear looks like you have a failing test!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user purplecabbage commented on a diff in the pull request:

        https://github.com/apache/cordova-cli/pull/256#discussion_r65622045

        — Diff: src/cli.js —
        @@ -464,12 +464,15 @@ function cli(inputArgs) {
        cfg.lib = cfg.lib || {};
        cfg.lib.www = wwwCfg;
        }
        -

        • // create(dir, id, name, cfg)
          + var fetchOpt = false;
          + if (args['fetch']) { + fetchOpt = true; + }

          return cordova.raw.create( undashed[1] // dir to create the project in
          , undashed[2] // App id
          , undashed[3] // App name
          , cfg
          + , fetchOpt

            • End diff –

        how about just passing?
        ``` args['fetch'] != undefined ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/256#discussion_r65622045 — Diff: src/cli.js — @@ -464,12 +464,15 @@ function cli(inputArgs) { cfg.lib = cfg.lib || {}; cfg.lib.www = wwwCfg; } - // create(dir, id, name, cfg) + var fetchOpt = false; + if (args ['fetch'] ) { + fetchOpt = true; + } return cordova.raw.create( undashed [1] // dir to create the project in , undashed [2] // App id , undashed [3] // App name , cfg + , fetchOpt End diff – how about just passing? ``` args ['fetch'] != undefined ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user carynbear opened a pull request:

        https://github.com/apache/cordova-cli/pull/256

        CB-11349 passing --fetch to create

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/carynbear/cordova-cli master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-cli/pull/256.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #256


        commit c007ca593b38c514af019ccf54f0612e1cc262d7
        Author: carynbear <caryn.tran@berkeley.edu>
        Date: 2016-06-02T18:17:28Z

        CB-11349 passing --fetch to create


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user carynbear opened a pull request: https://github.com/apache/cordova-cli/pull/256 CB-11349 passing --fetch to create You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-cli master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/256.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #256 commit c007ca593b38c514af019ccf54f0612e1cc262d7 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-02T18:17:28Z CB-11349 passing --fetch to create
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/cordova-lib/pull/446

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/446
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cc0e0e9ac2f1a589bb6a13be4a1d4299fe1bdba1 in cordova-lib's branch refs/heads/master from Caryn Tran
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=cc0e0e9 ]

        CB-11349 added --fetch and cordova fetch to create --template

        Show
        jira-bot ASF subversion and git services added a comment - Commit cc0e0e9ac2f1a589bb6a13be4a1d4299fe1bdba1 in cordova-lib's branch refs/heads/master from Caryn Tran [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=cc0e0e9 ] CB-11349 added --fetch and cordova fetch to create --template
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user stevengill commented on the issue:

        https://github.com/apache/cordova-lib/pull/446

        Looks great! I'll merge this in! Thanks @carynbear!!

        Show
        githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/446 Looks great! I'll merge this in! Thanks @carynbear!!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user codecov-io commented on the issue:

        https://github.com/apache/cordova-lib/pull/446

          1. [Current coverage][cc-pull] is *80.59%*
            > Merging 446[cc-pull] into [master][cc-base-branch] will increase coverage by *<.01%*

        ```diff
        @@ master #446 diff @@
        ==========================================
        Files 68 68
        Lines 5379 5384 +5
        Methods 851 851
        Messages 0 0
        Branches 1039 1041 +2
        ==========================================
        + Hits 4334 4339 +5
        Misses 1045 1045
        Partials 0 0
        ```

        > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [61f584d...3b4404c][cc-compare]
        [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
        [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/61f584de5891c52431e40a2dd534ac24cc081fcb...3b4404c31dec1882f4b267243c7206d0d922646d
        [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/446?src=pr

        Show
        githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/446 [Current coverage] [cc-pull] is * 80.59% * > Merging 446 [cc-pull] into [master] [cc-base-branch] will increase coverage by * <.01% * ```diff @@ master #446 diff @@ ========================================== Files 68 68 Lines 5379 5384 +5 Methods 851 851 Messages 0 0 Branches 1039 1041 +2 ========================================== + Hits 4334 4339 +5 Misses 1045 1045 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [61f584d...3b4404c] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-lib/compare/61f584de5891c52431e40a2dd534ac24cc081fcb...3b4404c31dec1882f4b267243c7206d0d922646d [cc-pull] : https://codecov.io/gh/apache/cordova-lib/pull/446?src=pr

          People

          • Assignee:
            carynbear Caryn Tran
            Reporter:
            carynbear Caryn Tran
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development