[CB-11292] calling loadUrl more than once breaks messageChannel

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-android
• Assignee: Joey Robert Bowser
• Reporter: Tony Homer
• Created: 18/May/16 16:32
• Updated: 23/Aug/18 06:56
• Resolved: 25/May/16 23:04

Description

CordovaWebViewImpl.sendJavascriptEvent caches a reference to the CoreAndroid plugin instance. This plugin manages Cordova's messageChannel. One of the things messageChannel is used for is sending system events from native to JS, for example backbutton events.

By default, CordovaWebViewImpl.loadUrl unloads all plugins. This has the side effect of rendering CordovaWebViewImpl's cached instance of CoreAndroid stale. That is, a new instance is created and bound to a new messageChannel callback.

After this happens, when CordovaWebViewImpl sends messages to JS, the callback id has changed and the messages are not handled.

There are at least 2 approaches that should fix this.
1. (tested) do not cache the CoreAndroid instance. If CordovaWebViewImpl.sendJavascriptEvent gets the reference from PluginManager every time, it will not become stale.
2. (not tested, but better encapsulated) when plugins are recreated, clear the cached reference

Issue Links

• links to: GitHub Pull Request #307