Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: Master
    • Fix Version/s: None
    • Component/s: cordova-lib
    • Labels:
    • Environment:

      Windows, OSX

      Description

      When running "npm test" in cordova-lib folder, the following test fails on Node 6.0.0:

        1) ios project handler uninstallation of <framework> elements with custom="true" attribute should rm the file from the right target location
         Message:
           TypeError: Path must be a string. Received undefined
         Stacktrace:
           TypeError: Path must be a string. Received undefined
          at assertPath (path.js:7:11)
          at Object.dirname (path.js:697:5)
          at searchPathForFile (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
          at pbxProject.removeFromFrameworkSearchPaths (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
          at pbxProject.removeFramework (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
          at Object.module.exports.framework.uninstall (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
          at .<anonymous> (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
      

      Initial investigation points out that the bug in node-xcode can be the cause of this.

      The bug breaks uninstallation of plugins with custom frameworks for iOS platform, such as Facebook plugin.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/437

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/437
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the pull request:

          https://github.com/apache/cordova-lib/pull/437#issuecomment-218113832

            1. [Current coverage][cc-pull] is *80.59%*
              > Merging 437[cc-pull] into [master][cc-base-branch] will not change coverage

          ```diff
          @@ master #437 diff @@
          ==========================================
          Files 68 68
          Lines 5353 5353
          Methods 851 851
          Messages 0 0
          Branches 1027 1027
          ==========================================
          Hits 4314 4314
          Misses 1039 1039
          Partials 0 0
          ```

          > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [6025a5f...7ca35ae][cc-compare]
          [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
          [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/6025a5f23c00284fb3416d8042ff5d738bf03db3...7ca35ae10216c092f6254109e44094c23f44999e
          [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/437?src=pr

          Show
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/437#issuecomment-218113832 [Current coverage] [cc-pull] is * 80.59% * > Merging 437 [cc-pull] into [master] [cc-base-branch] will not change coverage ```diff @@ master #437 diff @@ ========================================== Files 68 68 Lines 5353 5353 Methods 851 851 Messages 0 0 Branches 1027 1027 ========================================== Hits 4314 4314 Misses 1039 1039 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [6025a5f...7ca35ae] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-lib/compare/6025a5f23c00284fb3416d8042ff5d738bf03db3...7ca35ae10216c092f6254109e44094c23f44999e [cc-pull] : https://codecov.io/gh/apache/cordova-lib/pull/437?src=pr
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-ios/pull/221

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/221
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilkh commented on the pull request:

          https://github.com/apache/cordova-ios/pull/221#issuecomment-217920442

          LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/221#issuecomment-217920442 LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the pull request:

          https://github.com/apache/cordova-ios/pull/221#issuecomment-217580068

            1. [Current coverage][cc-pull] is *54.57%*
              > Merging 221[cc-pull] into [master][cc-base-branch] will not change coverage

          ```diff
          @@ master #221 diff @@
          ==========================================
          Files 11 11
          Lines 821 821
          Methods 118 118
          Messages 0 0
          Branches 138 138
          ==========================================
          Hits 448 448
          Misses 373 373
          Partials 0 0
          ```

          > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [f41737d...d2bab20][cc-compare]
          [cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
          [cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/f41737d014b3621247d6d5283ebd81f0c6720c31...d2bab201aca5140dab7ef5b489a29cd5c51f54ec
          [cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/221?src=pr

          Show
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the pull request: https://github.com/apache/cordova-ios/pull/221#issuecomment-217580068 [Current coverage] [cc-pull] is * 54.57% * > Merging 221 [cc-pull] into [master] [cc-base-branch] will not change coverage ```diff @@ master #221 diff @@ ========================================== Files 11 11 Lines 821 821 Methods 118 118 Messages 0 0 Branches 138 138 ========================================== Hits 448 448 Misses 373 373 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [f41737d...d2bab20] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-ios/compare/f41737d014b3621247d6d5283ebd81f0c6720c31...d2bab201aca5140dab7ef5b489a29cd5c51f54ec [cc-pull] : https://codecov.io/gh/apache/cordova-ios/pull/221?src=pr
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-ios/pull/221

          CB-11200 Bump node-xcode version

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-ios CB-11200

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/221.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #221


          commit 58f3392722e0af66da55bd9ce87c29313ff4c158
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2016-05-06T21:16:51Z

          CB-11200 Bump node-xcode version


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/221 CB-11200 Bump node-xcode version You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-11200 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #221 commit 58f3392722e0af66da55bd9ce87c29313ff4c158 Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2016-05-06T21:16:51Z CB-11200 Bump node-xcode version
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-lib/pull/437

          CB-11200 Bump xcode dependency and update tests to pass

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-lib CB-11200

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/437.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #437


          commit 8148cdbe6b078e8001dc6ba0f9c6ca3ef5725229
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2016-05-06T21:12:10Z

          CB-11200 Bump xcode dependency and update tests to pass


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/437 CB-11200 Bump xcode dependency and update tests to pass You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-11200 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/437.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #437 commit 8148cdbe6b078e8001dc6ba0f9c6ca3ef5725229 Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2016-05-06T21:12:10Z CB-11200 Bump xcode dependency and update tests to pass
          Hide
          vladimir.kotikov Vladimir Kotikov added a comment -

          Here is the PR to node-xcode: https://github.com/alunny/node-xcode/pull/86

          Show
          vladimir.kotikov Vladimir Kotikov added a comment - Here is the PR to node-xcode: https://github.com/alunny/node-xcode/pull/86
          Hide
          nikhilkh Nikhil Khandelwal added a comment -

          After we fix this - we should ensure travis runs these tests with node 6.0 in addition to other older versions of node.

          Show
          nikhilkh Nikhil Khandelwal added a comment - After we fix this - we should ensure travis runs these tests with node 6.0 in addition to other older versions of node.

            People

            • Assignee:
              vladimir.kotikov Vladimir Kotikov
              Reporter:
              alsorokin Alexander Sorokin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development