Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-11115

Encoding error on Android N in file plugin mobilespec test

Details

    Description

      There are three file plugin specs that fail on Android N developer preview 2: 138, 139, and 140. Each fails with the same error:

      resolveLocalFileSystemURL failed for content provider {"code":5}: ENCODING_ERR
      

      Seems to be an issue with resolving content:// URIs

      Attachments

        Issue Links

          Activity

            Marking this as a test error, since the issue appears to be that our tests were relying on parsing the toString of a FileDescriptor and that toString must have changed in N.

            Here: https://github.com/apache/cordova-plugin-file/blob/master/tests/src/android/TestContentProvider.java#L55

            riknoll Richard B Knoll added a comment - Marking this as a test error, since the issue appears to be that our tests were relying on parsing the toString of a FileDescriptor and that toString must have changed in N. Here: https://github.com/apache/cordova-plugin-file/blob/master/tests/src/android/TestContentProvider.java#L55
            githubbot ASF GitHub Bot added a comment -

            GitHub user riknoll opened a pull request:

            https://github.com/apache/cordova-plugin-file/pull/178

            CB-11115 android: Fixing test content provider

            Seems like `FileDescriptor.toString()` changed in Android N and it broke three of our tests. This removes our dependency on the output of that. Tested on N and Marshmallow.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-11115

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-file/pull/178.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #178


            commit fe7b78142d02aa2b28056d8472728ce90ad331e0
            Author: Richard Knoll <richard.b.knoll@gmail.com>
            Date: 2016-04-20T00:14:01Z

            CB-11115 android: Removing dependency on FileDescriptor toString in content provider tests


            githubbot ASF GitHub Bot added a comment - GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file/pull/178 CB-11115 android: Fixing test content provider Seems like `FileDescriptor.toString()` changed in Android N and it broke three of our tests. This removes our dependency on the output of that. Tested on N and Marshmallow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-11115 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #178 commit fe7b78142d02aa2b28056d8472728ce90ad331e0 Author: Richard Knoll <richard.b.knoll@gmail.com> Date: 2016-04-20T00:14:01Z CB-11115 android: Removing dependency on FileDescriptor toString in content provider tests
            githubbot ASF GitHub Bot added a comment -

            Github user riknoll commented on the pull request:

            https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212539984

            @infil00p does this change seem reasonable to you? I tried to match the old behavior.

            githubbot ASF GitHub Bot added a comment - Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212539984 @infil00p does this change seem reasonable to you? I tried to match the old behavior.
            githubbot ASF GitHub Bot added a comment -

            Github user infil00p commented on the pull request:

            https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540487

            @riknoll LGTM

            githubbot ASF GitHub Bot added a comment - Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540487 @riknoll LGTM
            githubbot ASF GitHub Bot added a comment -

            Github user riknoll commented on the pull request:

            https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540628

            Thanks!

            githubbot ASF GitHub Bot added a comment - Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/178#issuecomment-212540628 Thanks!

            Commit fe7b78142d02aa2b28056d8472728ce90ad331e0 in cordova-plugin-file's branch refs/heads/master from Richard Knoll
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=fe7b781 ]

            CB-11115 android: Removing dependency on FileDescriptor toString in content provider tests

            jira-bot ASF subversion and git services added a comment - Commit fe7b78142d02aa2b28056d8472728ce90ad331e0 in cordova-plugin-file's branch refs/heads/master from Richard Knoll [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=fe7b781 ] CB-11115 android: Removing dependency on FileDescriptor toString in content provider tests
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-file/pull/178

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/178

            People

              riknoll Richard B Knoll
              riknoll Richard B Knoll
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: