Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
1.0.0, (28)
1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0, 1.6.1, 1.7.0, 1.8.0, 1.8.1, 1.9.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0, 3.0.0, 3.1.0, 3.2.0, 3.3.0, 3.4.0, 2.9.1, 3.5.0 -
None
Description
AudioHandler.java should use android.util.Log rather than println.
Attachments
Issue Links
- links to
Activity
GitHub user sanjeewa894 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/110
CB-11085 (Android) Fixed AudioHandler logs should use system log, not println
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
Android
- Platforms affected
-
-
-
- What does this PR do?
This is a fix for https://issues.apache.org/jira/browse/CB-11085.
It fixes the println to LOG (android.util.Log use in org.apache.cordova.LOG).
- What does this PR do?
-
-
-
- What testing has been done on this change?
Testing was unable to do.
- What testing has been done on this change?
-
-
-
- Checklist
-
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjeewa894/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
commit 9084576e1a6853c82457e2d379fb3d2a0e3364f6
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:44:29Z
Fix error output using println to Log.e
commit fac888da1b8cf88eb1fc44ac3a0e94b6d0030dbb
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:46:05Z
Merge remote-tracking branch 'origin/master'
commit c1c01b1834e1a37158b6de247ac444a1d49fbdbf
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:53:12Z
Fix error output using println to LOG.e
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/110
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/110/commits/c1c01b1834e1a37158b6de247ac444a1d49fbdbf)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/63/)
Can I know how to build test case for this fix? Is it build as usual java
test case or something else?
Github user daserge commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/110
@sanjeewa894, you should not close your PRs in case you want them to be merged in.
PRs are sometimes being closed by asfgit bot, which occurs when a commit contains "Closes #PR-NUMBER" string - this usually occurs either for PRs that had been merged already (and not automatically closed by Github because of different commit SHAs) or for invalid/stale ones (if their authors don't respond and close them per request).
GitHub user sanjeewa894 reopened a pull request:
https://github.com/apache/cordova-plugin-media/pull/110
CB-11085 (Android) Fixed AudioHandler logs should use system log, not println
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
Android
- Platforms affected
-
-
-
- What does this PR do?
This is a fix for https://issues.apache.org/jira/browse/CB-11085.
It fixes the println to LOG (android.util.Log use in org.apache.cordova.LOG).
- What does this PR do?
-
-
-
- What testing has been done on this change?
Testing was unable to do.
- What testing has been done on this change?
-
-
-
- Checklist
-
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjeewa894/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
commit 9084576e1a6853c82457e2d379fb3d2a0e3364f6
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:44:29Z
Fix error output using println to Log.e
commit fac888da1b8cf88eb1fc44ac3a0e94b6d0030dbb
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:46:05Z
Merge remote-tracking branch 'origin/master'
commit c1c01b1834e1a37158b6de247ac444a1d49fbdbf
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date: 2016-08-23T17:53:12Z
Fix error output using println to LOG.e
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/110
Cordova CI Build has one or more failures.
*Commit* - [Link](https://github.com/apache/cordova-plugin-media/pull/110/commits/c1c01b1834e1a37158b6de247ac444a1d49fbdbf)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/64/)
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/110
LGTM. I'll merge it in. Thanks @sanjeewa894 for sending the PR!!
Commit 1dc6ecfbb4473401bdafd2ae4271da9a0b45ad7e in cordova-plugin-media's branch refs/heads/master from sanjeewa894
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=1dc6ecf ]
CB-11085 Fix error output using println to LOG.e
This closes #110
Github user fafaman commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211828264
@omefire I am not too keen on seeking to the end of file: Is this module not supposed to be able to play a stream? To be clear, this patch was done while looking after a problem of codrova app restarting when the phone is plugged or unplugged from a car audio stand. I seams that an event telling the app the audio system has changed provoques that app restart. I first thought the app restart was due to that null pointer exception, but once fixed, the app still restarts... I decided to propose the patch (as well as
CB-11085) so this work is not lost, and code cleaner for going forward. In my opinion, the real problem comes from before during the player creation: we should not have this.players.get(id) returning a non null while the player is null.