[CB-10977] Overlapping permission requests in Android can cause errors

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Component/s: cordova-plugin-file
• Labels: android mustfix reproduced triaged

Environment

Marshmallow

• Assignee: Richard B Knoll
• Reporter: Richard B Knoll
• Created: 28/Mar/16 19:02
• Updated: 30/Mar/16 18:03
• Resolved: 30/Mar/16 18:03

Description

We use global state for permission requests in the file plugin that gets overwritten on each call to the plugin. That means that if multiple writes/reads are performed while the permission request is pending, the global state will get overwritten and callbacks will not be returned correctly. For example,

getFile('test1', {create:true}, function(){}, function(){});
getDirectory('test2', {create:true}, function(){}, function(){});

In the above code block, only the second call (getDirectory) would get a success or error callback. Furthermore, this code will attempt to create both a directory and a file named test1 because the permission callback for the first call will be executed using the arguments from the second call.