Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
6.0.0
-
None
-
Windows Phone 10, cordova-windows@4.3.1, cordova-plugin-inappbrowser@1.2.1
Description
When setting location=yes, the height of the webview is by some pixels too small. Please see attached screenshot with the green remarks.
ref = cordova.InAppBrowser.open(h, '_blank', 'location=yes fullscreen=yes');
Attachments
Attachments
- inAppBrowser-wrong-height.png
- 218 kB
- Roberto De Simone
- wp_ss_20170510_0001.png
- 114 kB
- Roberto De Simone
Issue Links
Activity
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
Commit f8747a700d7bb214b01a1864760403ee95d1bb98 in cordova-plugin-inappbrowser's branch refs/heads/master from daserge
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=f8747a7 ]
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes
Redoing as there was still a little gap
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
Cordova CI Build has completed successfully.
*Commit* - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/193/commits/19182dace270697a5c41416c654159bb0c542b35)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/87/)
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193
CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…
…ith location=yes
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
Windows
- Platforms affected
-
-
-
- What does this PR do?
Redoing as there was still a little gap
- What does this PR do?
-
-
-
- What testing has been done on this change?
Tested on Windows Phone 8.1 Lumia 640, 525,
Windows 10 Mobile 525, 1520,
Windows 10 desktop
- What testing has been done on this change?
-
-
-
- Checklist
-
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
commit 19182dace270697a5c41416c654159bb0c542b35
Author: daserge <v-seshak@microsoft.com>
Date: 2016-10-19T09:52:11Z
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes
Redoing as there was still a little gap
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/181
Cordova CI Build has completed successfully.
*Commit* - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/181/commits/60d27b8d8db5c66e5879b9c228e10b2811525441)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/63/)
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/181
Commit 60d27b8d8db5c66e5879b9c228e10b2811525441 in cordova-plugin-inappbrowser's branch refs/heads/master from daserge
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=60d27b8 ]
CB-10973 inAppBrowser for Browser Platform: wrong height of webview with location=yes
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/181
CB-10973 inAppBrowser for Browser Platform: wrong height of webview w…
…ith location=yes
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
Browser
- Platforms affected
-
-
-
- What does this PR do?
The same as https://github.com/apache/cordova-plugin-inappbrowser/pull/180 for Browser platform
- What does this PR do?
-
-
-
- What testing has been done on this change?
Firefox, Chrome, Edge, IE11
- What testing has been done on this change?
-
-
-
- Checklist
-
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973-browser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
commit 60d27b8d8db5c66e5879b9c228e10b2811525441
Author: daserge <v-seshak@microsoft.com>
Date: 2016-08-22T14:31:58Z
CB-10973 inAppBrowser for Browser Platform: wrong height of webview with location=yes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180
Commit a77b289f0132e71f635cf692d816c47d42efe972 in cordova-plugin-inappbrowser's branch refs/heads/master from daserge
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a77b289 ]
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180
Cordova CI Build has completed successfully.
*Commit* - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/180/commits/a77b289f0132e71f635cf692d816c47d42efe972)
*Dashboard* - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/62/)
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180
CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…
…ith location=yes
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
-
-
- Platforms affected
Windows
- Platforms affected
-
-
-
- What does this PR do?
Removes a transparent gap between x-ms-webview and bottom appbar.
- What does this PR do?
-
-
-
- What testing has been done on this change?
Windows 8.1/10, Windows Phone 8.1/10, normal and fullscreen modes, portrait and landscape orientations.
- What testing has been done on this change?
-
-
-
- Checklist
-
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
[Jira issue](https://issues.apache.org/jira/browse/CB-10973)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #180
commit a77b289f0132e71f635cf692d816c47d42efe972
Author: daserge <v-seshak@microsoft.com>
Date: 2016-08-19T14:43:48Z
CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes
IMO the issue is not solved. Now the gap is at the bottom. Please see screen shot:
https://issues.apache.org/jira/secure/attachment/12867284/wp_ss_20170510_0001.png