Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10916

Add ability to set different binary name and display name

    Details

      Description

      I would like to use a different value for the binary filenames (.ipa/.apk) and the app display name. Currently <name> in config.xml is used for both.

      If I set <name> to the value I want for the binary name, I have to manually edit app_name in res/values/strings.xml and CFBundleDisplayName in *-Info.plist.

      On the other hand, if I set <name> to the value I want for the display name, I can manually rename the binaries, but the iOS .ipa file still contains an .app file with the display name, and CFBundleExecutable still has the display name.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-docs/pull/709

          @janpio Check out https://issues.apache.org/jira/browse/CB-10916 – shows that two PRs to android and ios were pulled in for this feature.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/709 @janpio Check out https://issues.apache.org/jira/browse/CB-10916 – shows that two PRs to android and ios were pulled in for this feature.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user janpio commented on the issue:

          https://github.com/apache/cordova-docs/pull/709

          A bit late to the party, but where does this actually apply and work? (iOS, Android, Windows?)

          Show
          githubbot ASF GitHub Bot added a comment - Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/709 A bit late to the party, but where does this actually apply and work? (iOS, Android, Windows?)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-docs/pull/709

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/709
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a6dd5c3948d9bff310908c340fb2158038a56e09 in cordova-docs's branch refs/heads/master from Darryl Pogue
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=a6dd5c3 ]

          CB-10916 - Add documentation about display name

          This closes #709

          Show
          jira-bot ASF subversion and git services added a comment - Commit a6dd5c3948d9bff310908c340fb2158038a56e09 in cordova-docs's branch refs/heads/master from Darryl Pogue [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=a6dd5c3 ] CB-10916 - Add documentation about display name This closes #709
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-android/pull/310

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/310
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 22645d9158075b99d43cdcd9551c52a3bcf9ed29 in cordova-android's branch refs/heads/master from Darryl Pogue
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=22645d9 ]

          CB-10916 Support display name for Android

          Show
          jira-bot ASF subversion and git services added a comment - Commit 22645d9158075b99d43cdcd9551c52a3bcf9ed29 in cordova-android's branch refs/heads/master from Darryl Pogue [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=22645d9 ] CB-10916 Support display name for Android
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-android/pull/310

          Sorry, been on vacation the past few weeks, but it looks like we've already bundled in the required version of cordova-common, so this is good to go!

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/310 Sorry, been on vacation the past few weeks, but it looks like we've already bundled in the required version of cordova-common, so this is good to go!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user infil00p commented on the issue:

          https://github.com/apache/cordova-android/pull/310

          This appears to have fell by the wayside. Why hasn't this been pulled into cordova-android?

          Show
          githubbot ASF GitHub Bot added a comment - Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/310 This appears to have fell by the wayside. Why hasn't this been pulled into cordova-android?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-docs/pull/709

          This will be in 4.4.1

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/709 This will be in 4.4.1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-docs/pull/709

          This feature will be in cordova-ios@4.4.1 or 4.5.0 (confirm before pulling in)

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/709 This feature will be in cordova-ios@4.4.1 or 4.5.0 (confirm before pulling in)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-android/pull/310

          iOS, cordova-lib has this pulled in, and also docs has a PR. Just waiting on this one to be pulled in.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/310 iOS, cordova-lib has this pulled in, and also docs has a PR. Just waiting on this one to be pulled in.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dpogue opened a pull request:

          https://github.com/apache/cordova-docs/pull/709

          CB-10916 - Add documentation about display name

          <!--
          Please make sure the checklist boxes are all checked before submitting the PR. The checklist
          is intended as a quick reference, for complete details please see our Contributor Guidelines:

          http://cordova.apache.org/contribute/contribute_guidelines.html

          Thanks!
          -->

              1. Platforms affected
              1. What does this PR do?
                Add documentation for `<name short="...">` to the config.xml reference page.
              1. What testing has been done on this change?
              1. Checklist
          • [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
          • [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
          • [ ] Added automated test coverage as appropriate for this change.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dpogue/cordova-docs short-name

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-docs/pull/709.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #709


          commit f9e4dff052291260e0ff5dbf46c77c48ce620ebe
          Author: Darryl Pogue <darryl@dpogue.ca>
          Date: 2017-06-11T00:44:28Z

          CB-10916 - Add documentation about display name


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dpogue opened a pull request: https://github.com/apache/cordova-docs/pull/709 CB-10916 - Add documentation about display name <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Add documentation for `<name short="...">` to the config.xml reference page. What testing has been done on this change? Checklist [x] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-docs short-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/709.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #709 commit f9e4dff052291260e0ff5dbf46c77c48ce620ebe Author: Darryl Pogue <darryl@dpogue.ca> Date: 2017-06-11T00:44:28Z CB-10916 - Add documentation about display name
          Hide
          shazron Shazron Abdullah added a comment -

          Darryl Pogue Do we have a docs issue for this? Please send a PR for that, and also pull in the android PR Thanks.

          Show
          shazron Shazron Abdullah added a comment - Darryl Pogue Do we have a docs issue for this? Please send a PR for that, and also pull in the android PR Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-ios/pull/228

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/228
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8c77a0b991ace06b470dba9496a24e6ef75c2be3 in cordova-ios's branch refs/heads/master from Darryl Pogue
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=8c77a0b ]

          CB-10916 Support display name for iOS

          This closes #228

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8c77a0b991ace06b470dba9496a24e6ef75c2be3 in cordova-ios's branch refs/heads/master from Darryl Pogue [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=8c77a0b ] CB-10916 Support display name for iOS This closes #228
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          @shazron All good now

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron All good now
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dpogue reopened a pull request:

          https://github.com/apache/cordova-ios/pull/228

          CB-10916 Support display name for iOS

          This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dpogue/cordova-ios short-name

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/228.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #228


          commit 92d9cdaacc698f23100df500edf35ff7f3c17fd1
          Author: Darryl Pogue <darryl@ayogo.com>
          Date: 2016-06-07T22:47:38Z

          CB-10916 Support display name for iOS


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 CB-10916 Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-ios short-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit 92d9cdaacc698f23100df500edf35ff7f3c17fd1 Author: Darryl Pogue <darryl@ayogo.com> Date: 2016-06-07T22:47:38Z CB-10916 Support display name for iOS
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue closed the pull request at:

          https://github.com/apache/cordova-ios/pull/228

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          @dpogue bah, same timeout error. Please do the close and re-open PR dance again

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 @dpogue bah, same timeout error. Please do the close and re-open PR dance again
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dpogue reopened a pull request:

          https://github.com/apache/cordova-ios/pull/228

          CB-10916 Support display name for iOS

          This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dpogue/cordova-ios short-name

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/228.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #228



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 CB-10916 Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-ios short-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue closed the pull request at:

          https://github.com/apache/cordova-ios/pull/228

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          @dpogue looks like a Simulator timeout. Can you close and re-open the PR to trigger the CI again
          @fredgalvao ditto what @dpogue said

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 @dpogue looks like a Simulator timeout. Can you close and re-open the PR to trigger the CI again @fredgalvao ditto what @dpogue said
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          @fredgalvao Personally, I think your idea is the right way to go in terms of project structure, and should definitely be brought up for discussion on the dev list (because it probably has implications beyond just the display name of the app and because we'd probably want all supported platforms to agree). The scope for this particular PR is just to update the name in the Info.plist.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @fredgalvao Personally, I think your idea is the right way to go in terms of project structure, and should definitely be brought up for discussion on the dev list (because it probably has implications beyond just the display name of the app and because we'd probably want all supported platforms to agree). The scope for this particular PR is just to update the name in the Info.plist.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fredgalvao commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          Should my previous comment go into an issue dedicated to discussion? There was no feedback on it, and it seems like there is a consensus into doing the simple version, which imo doesn't actually solve the root problem (and could solve many other problems if overhauled).

          @shazron @dpogue I'm honestly interested in at least knowing your reasoning and opinion regarding my previously stated PoV on the topic. Who knows, maybe I'm even using an overly complex solution on my side.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fredgalvao commented on the issue: https://github.com/apache/cordova-ios/pull/228 Should my previous comment go into an issue dedicated to discussion? There was no feedback on it, and it seems like there is a consensus into doing the simple version, which imo doesn't actually solve the root problem (and could solve many other problems if overhauled). @shazron @dpogue I'm honestly interested in at least knowing your reasoning and opinion regarding my previously stated PoV on the topic. Who knows, maybe I'm even using an overly complex solution on my side.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          @shazron This can go in to 4.4.1 now that cordova-common changes are merged

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron This can go in to 4.4.1 now that cordova-common changes are merged
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-android/pull/310

          Will do :+1:

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/310 Will do :+1:
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user infil00p commented on the issue:

          https://github.com/apache/cordova-android/pull/310

          Looks fine, but we should wait for it all to go in together if possible. @dpogue You have commit rights, so can you make sure that this gets pulled in when the parent issue gets resolved?

          Show
          githubbot ASF GitHub Bot added a comment - Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/310 Looks fine, but we should wait for it all to go in together if possible. @dpogue You have commit rights, so can you make sure that this gets pulled in when the parent issue gets resolved?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fredgalvao commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          Is there any reason why this PR doesn't also export `CFBundleName` as the result of the short name on config.xml? Follow me for a while:

          According to [this page on the developer portal](https://developer.apple.com/library/content/qa/qa1892/_index.html) it seems like these two properties go along and, unless they are too big, should most probably have the same value.

          Now, with the recent findings and issues related to renaming projects (which causes malformed pbxproj files and unsolvable string search&replace operations), it seems to me like we could simply leave the project structure and project name (not to be confused with app name) a generic static value, and deal with the `<name>` and `<short-name>` outputing them to `CFBundleDisplayName` and `CFBundleName` respectively.

          That's what I did when I evolved my cordova project into a whitelabel, so that I could generate different apps with the same code base. However, in my case I needed to use a string replacement on `build.gradle` to set the `applicationId` on android (the app name works fine, it's updated in the string.xml correctly and my main activity class doesn't need to be renamed). There's an [issue](https://issues.apache.org/jira/browse/CB-11374) for the `applicationId` thing too, btw. On iOS, I also had to use [cordova-plugin-app-name](https://github.com/blakgeek/cordova-plugin-app-name/blob/master/plugin.xml) to deal with the "renaming breaks the project" issue (leaving the `<name>` untouched, otherwise I'd be screwed).

            1. Summary of my opinion

          To evolve into a more whitelabel-friendly structure with respect to naming apps:

          • Evolve `<name>` and `<short-name>` handling to affect *ONLY* {`strings.xml`@`app_name`}

            on android, and

            {`CFBundleName` + `CFBundleDisplayName`}

            on iOS, leaving the following items with a generic static name [activity class name on android, xcode project files (plist, pbxproj)].

          Please @shazron and @dpogue tell me what you think of all of this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fredgalvao commented on the issue: https://github.com/apache/cordova-ios/pull/228 Is there any reason why this PR doesn't also export `CFBundleName` as the result of the short name on config.xml? Follow me for a while: According to [this page on the developer portal] ( https://developer.apple.com/library/content/qa/qa1892/_index.html ) it seems like these two properties go along and, unless they are too big, should most probably have the same value. Now, with the recent findings and issues related to renaming projects (which causes malformed pbxproj files and unsolvable string search&replace operations), it seems to me like we could simply leave the project structure and project name (not to be confused with app name) a generic static value, and deal with the `<name>` and `<short-name>` outputing them to `CFBundleDisplayName` and `CFBundleName` respectively. That's what I did when I evolved my cordova project into a whitelabel, so that I could generate different apps with the same code base. However, in my case I needed to use a string replacement on `build.gradle` to set the `applicationId` on android (the app name works fine, it's updated in the string.xml correctly and my main activity class doesn't need to be renamed). There's an [issue] ( https://issues.apache.org/jira/browse/CB-11374 ) for the `applicationId` thing too, btw. On iOS, I also had to use [cordova-plugin-app-name] ( https://github.com/blakgeek/cordova-plugin-app-name/blob/master/plugin.xml ) to deal with the "renaming breaks the project" issue (leaving the `<name>` untouched, otherwise I'd be screwed). Summary of my opinion To evolve into a more whitelabel-friendly structure with respect to naming apps: Evolve `<name>` and `<short-name>` handling to affect * ONLY * {`strings.xml`@`app_name`} on android, and {`CFBundleName` + `CFBundleDisplayName`} on iOS, leaving the following items with a generic static name [activity class name on android, xcode project files (plist, pbxproj)] . Please @shazron and @dpogue tell me what you think of all of this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          I would like this in 4.3.0. Hopefully we can resolve https://github.com/apache/cordova-lib/pull/453 for cordova-cli 6.4.0

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 I would like this in 4.3.0. Hopefully we can resolve https://github.com/apache/cordova-lib/pull/453 for cordova-cli 6.4.0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dpogue commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          Rebased, but still blocked on the cordova-lib PR

          Show
          githubbot ASF GitHub Bot added a comment - Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 Rebased, but still blocked on the cordova-lib PR
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          This PR needs to be re-based.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 This PR needs to be re-based.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

            1. [Current coverage][cc-pull] is *51.97%*
              > Merging 228[cc-pull] into [master][cc-base-branch] will increase coverage by *0.16%*

          ```diff
          @@ master #228 diff @@
          ==========================================
          Files 11 11
          Lines 882 885 +3
          Methods 132 132
          Messages 0 0
          Branches 143 145 +2
          ==========================================
          + Hits 457 460 +3
          Misses 425 425
          Partials 0 0
          ```

          > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2e41e22...322bd50][cc-compare]
          [cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
          [cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/2e41e221d50dd00b832879cd3b4ced372f8be428...322bd50cf9ae5db857655bdc0da78dae07a12ade
          [cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/228?src=pr

          Show
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/228 [Current coverage] [cc-pull] is * 51.97% * > Merging 228 [cc-pull] into [master] [cc-base-branch] will increase coverage by * 0.16% * ```diff @@ master #228 diff @@ ========================================== Files 11 11 Lines 882 885 +3 Methods 132 132 Messages 0 0 Branches 143 145 +2 ========================================== + Hits 457 460 +3 Misses 425 425 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [2e41e22...322bd50] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-ios/compare/2e41e221d50dd00b832879cd3b4ced372f8be428...322bd50cf9ae5db857655bdc0da78dae07a12ade [cc-pull] : https://codecov.io/gh/apache/cordova-ios/pull/228?src=pr
          Hide
          tripod Tobias Bocanegra added a comment - - edited

          shouldn't we add this feature for all platforms?
          at least for OSX, this would be useful as well.

          I created a follow up bug to OSX: CB-11400

          Show
          tripod Tobias Bocanegra added a comment - - edited shouldn't we add this feature for all platforms? at least for OSX, this would be useful as well. I created a follow up bug to OSX: CB-11400
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shazron commented on the issue:

          https://github.com/apache/cordova-ios/pull/228

          Pull in when we bundle update to the released cordova-common that includes https://github.com/apache/cordova-lib/pull/453

          Show
          githubbot ASF GitHub Bot added a comment - Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 Pull in when we bundle update to the released cordova-common that includes https://github.com/apache/cordova-lib/pull/453
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dpogue opened a pull request:

          https://github.com/apache/cordova-ios/pull/228

          CB-10916 Support display name for iOS

          This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dpogue/cordova-ios short-name

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/228.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #228


          commit 322bd50cf9ae5db857655bdc0da78dae07a12ade
          Author: Darryl Pogue <darryl@ayogo.com>
          Date: 2016-06-07T22:47:38Z

          CB-10916 Support display name for iOS


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/228 CB-10916 Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-ios short-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit 322bd50cf9ae5db857655bdc0da78dae07a12ade Author: Darryl Pogue <darryl@ayogo.com> Date: 2016-06-07T22:47:38Z CB-10916 Support display name for iOS
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the issue:

          https://github.com/apache/cordova-android/pull/310

            1. [Current coverage][cc-pull] is *34.14%*
              > Merging 310[cc-pull] into [master][cc-base-branch] will not change coverage

          ```diff
          @@ master #310 diff @@
          ==========================================
          Files 11 11
          Lines 949 949
          Methods 195 195
          Messages 0 0
          Branches 153 153
          ==========================================
          Hits 324 324
          Misses 625 625
          Partials 0 0
          ```

          > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [81d6219...acf5858][cc-compare]
          [cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
          [cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/81d6219663ee4c9100a7bdaab49f5cf58c82e578...acf58587d83618df99471f389ab7dc3b150fb674
          [cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/310?src=pr

          Show
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/310 [Current coverage] [cc-pull] is * 34.14% * > Merging 310 [cc-pull] into [master] [cc-base-branch] will not change coverage ```diff @@ master #310 diff @@ ========================================== Files 11 11 Lines 949 949 Methods 195 195 Messages 0 0 Branches 153 153 ========================================== Hits 324 324 Misses 625 625 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [81d6219...acf5858] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-android/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-android/compare/81d6219663ee4c9100a7bdaab49f5cf58c82e578...acf58587d83618df99471f389ab7dc3b150fb674 [cc-pull] : https://codecov.io/gh/apache/cordova-android/pull/310?src=pr
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dpogue opened a pull request:

          https://github.com/apache/cordova-android/pull/310

          CB-10916 Support display name for Android

          This is the Android Platform API support side of https://github.com/apache/cordova-lib/pull/453.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dpogue/cordova-android short-name

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-android/pull/310.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #310


          commit acf58587d83618df99471f389ab7dc3b150fb674
          Author: Darryl Pogue <darryl@ayogo.com>
          Date: 2016-06-07T20:02:18Z

          CB-10916 Support display name for Android


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/310 CB-10916 Support display name for Android This is the Android Platform API support side of https://github.com/apache/cordova-lib/pull/453 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/dpogue/cordova-android short-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #310 commit acf58587d83618df99471f389ab7dc3b150fb674 Author: Darryl Pogue <darryl@ayogo.com> Date: 2016-06-07T20:02:18Z CB-10916 Support display name for Android

            People

            • Assignee:
              dpogue Darryl Pogue
              Reporter:
              jweber Jacob Weber
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development