Apache Cordova
  1. Apache Cordova
  2. CB-1091

Installer: remove use of PackageMaker for Mountain Lion (OS X 10.8)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: iOS
    • Labels:
      None

      Description

      This is because of GateKeeper:

      1. http://www.macworld.com/article/1165408/mountain_lion_hands_on_with_gatekeeper.html
      2. http://en.wikipedia.org/wiki/Gatekeeper_(OS_X)

      We don't want to go into the hassle of signing a .pkg binary.

      This is less of a Cordova concern since we ship the source, but our makefile should not create a proprietary installer but just install what is needed (no one reads the notices in the installer anyway!)

      Since we are already requiring devs to use the command line to create new projects, requiring them to run an install script is not a problem.

        Issue Links

          Activity

          Shazron Abdullah created issue -
          Shazron Abdullah made changes -
          Field Original Value New Value
          Assignee Shazron Abdullah [ shazron ] Filip Maj [ filmaj ]
          Hide
          Filip Maj added a comment -

          Hey Shaz,

          I've got a branch pushed to apache for this:

          Branch 1091

          Can you run through the motions and let me know if you think this is good enough. Essentially:

          • axed all markdown/wkhtml/packager dependencies + options from makefile
          • moved the old post-install script into the install target of the makefile

          I ran through with having an older cordova version (1.9) installed with a template, and also tried after removing/uninstalling it. The bin/create then cordova/debug commands seemed to work OK, but I would appreciate it if you could double-check as I do not feel 100% confident that I covered all use cases and made all necessary changes.

          Thanks!

          Show
          Filip Maj added a comment - Hey Shaz, I've got a branch pushed to apache for this: Branch 1091 Can you run through the motions and let me know if you think this is good enough. Essentially: axed all markdown/wkhtml/packager dependencies + options from makefile moved the old post-install script into the install target of the makefile I ran through with having an older cordova version (1.9) installed with a template, and also tried after removing/uninstalling it. The bin/create then cordova/debug commands seemed to work OK, but I would appreciate it if you could double-check as I do not feel 100% confident that I covered all use cases and made all necessary changes. Thanks!
          Filip Maj made changes -
          Assignee Filip Maj [ filmaj ] Shazron Abdullah [ shazron ]
          Hide
          Shazron Abdullah added a comment -

          Hi Fil,
          I like the way you did it - I assume a dev will extract the source to a permanent location, run "make install" to install the variables etc, correct? This way if we have versioned installs (say through homebrew), we just run "make install" in the current versioned folder to set the right version.

          If an app uses a specific version, they can just modify their $(CORDOVALIB) variable in their CordovaBuildSettings.xcconfig to point to the right one (or a tool could do it).

          Show
          Shazron Abdullah added a comment - Hi Fil, I like the way you did it - I assume a dev will extract the source to a permanent location, run "make install" to install the variables etc, correct? This way if we have versioned installs (say through homebrew), we just run "make install" in the current versioned folder to set the right version. If an app uses a specific version, they can just modify their $(CORDOVALIB) variable in their CordovaBuildSettings.xcconfig to point to the right one (or a tool could do it).
          Hide
          Shazron Abdullah added a comment -

          One gotcha is, if Xcode is running, it will NOT update the variables (Xcode will overwrite when it shuts down). We could detect through the command line and warn if Xcode is running, I suppose.

          ps aux | grep -i "Xcode.app/Contents/MacOS/Xcode" | grep -v grep
          
          Show
          Shazron Abdullah added a comment - One gotcha is, if Xcode is running, it will NOT update the variables (Xcode will overwrite when it shuts down). We could detect through the command line and warn if Xcode is running, I suppose. ps aux | grep -i "Xcode.app/Contents/MacOS/Xcode" | grep -v grep
          Hide
          Filip Maj added a comment -

          Yeah, make install (or even just make) should check for xcode and drop the variables.

          Sweet. I'll add the "is-Xcode-running" thing to the branch. Should we run this by the ML?

          Other than that things checked out OK on your end?

          Show
          Filip Maj added a comment - Yeah, make install (or even just make ) should check for xcode and drop the variables. Sweet. I'll add the "is-Xcode-running" thing to the branch. Should we run this by the ML? Other than that things checked out OK on your end?
          Hide
          Shazron Abdullah added a comment -

          Thanks Fil, yeah let's run this through the ML. Thumbs up for me.

          Show
          Shazron Abdullah added a comment - Thanks Fil, yeah let's run this through the ML. Thumbs up for me.
          Hide
          Filip Maj added a comment -

          Added xcode check to the branch, and posted to the ML about it.

          Show
          Filip Maj added a comment - Added xcode check to the branch, and posted to the ML about it.
          Shazron Abdullah made changes -
          Link This issue blocks CB-1153 [ CB-1153 ]
          Show
          Shazron Abdullah added a comment - Branch 1091 merged in. http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/52ba5968
          Shazron Abdullah made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Link This issue blocks CB-1153 [ CB-1153 ]
          Gavin made changes -
          Link This issue is depended upon by CB-1153 [ CB-1153 ]

            People

            • Assignee:
              Shazron Abdullah
              Reporter:
              Shazron Abdullah
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development