[CB-10895] Transparent Splashscreen view sometimes remains

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Component/s: cordova-plugin-splashscreen
• Labels: iOS triaged

Environment

iPhone, iOS 9, Cordova 6.0.0, OSX Yosemite, XCode 7.2

• Assignee: Sergey Shakhnazarov
• Reporter: Andrew Ewanchyna
• Created: 17/Mar/16 18:10
• Updated: 23/Aug/18 06:57
• Resolved: 24/Mar/16 16:26

Description

If another view appears before the splash screen view has completed its animation, the splash screen view may remain in a transparent state, even after the blocking view is removed.

Problem traces to CDVSplashScreen.m line 450:
if (finished) {
[weakSelf destroyViews];

where the finished flag doesn't get set during the fade-out animation completion callback. This may occur if another view appears while the fade-out animation is running. When this happens, there is no way to remove the invisible view that remains.

I've removed the check to temporarily fix the problem. I've noticed that other plugins that have this type of logic don't usually include the check. The current logic doesn't seem to allow for a recovery when the finished flag is false.