Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-1079

Remove Named Args

VotersWatch issueWatchersLinkUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The following list is everywhere that the native side is using JSON DataContract serialization. Change these methods to expect an array of values instead of the current namedArguments.

      Commands\Camera.cs(199): new CameraOptions() : JSON.JsonHelper.Deserialize<CameraOptions>(options);
      Commands\Capture.cs(248): CaptureImageOptions.Default : JSON.JsonHelper.Deserialize<CaptureImageOptions>(options);
      Commands\Capture.cs(279): CaptureAudioOptions.Default : JSON.JsonHelper.Deserialize<CaptureAudioOptions>(options);
      Commands\Capture.cs(310): CaptureVideoOptions.Default : JSON.JsonHelper.Deserialize<CaptureVideoOptions>(options);
      Commands\Capture.cs(347): mediaFormatOptions = JSON.JsonHelper.Deserialize<MediaFormatOptions>(options);
      Commands\Capture.cs(406): file = String.IsNullOrEmpty(options) ? null : JSON.JsonHelper.Deserialize<MediaFile>(options);
      Commands\Compass.cs(264): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
      Commands\Compass.cs(299): compassOptions = JSON.JsonHelper.Deserialize<CompassOptions>(options);
      Commands\Contacts.cs(200): JSONContact contact = JSON.JsonHelper.Deserialize<JSONContact>(jsonContact);
      Commands\Contacts.cs(375): ContactSearchParams searchParams = JSON.JsonHelper.Deserialize<ContactSearchParams>(searchCriteria);
      Commands\File.cs(430): fileOptions = JSON.JsonHelper.Deserialize<FileOptions>(options);
      Commands\FileTransfer.cs(254): uploadOptions = JSON.JsonHelper.Deserialize<UploadOptions>(options);
      Commands\FileTransfer.cs(290): downloadOptions = JSON.JsonHelper.Deserialize<DownloadOptions>(options);
      Commands\Media.cs(69): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(115): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(159): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(200): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(231): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(284): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(330): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(373): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(421): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Media.cs(461): mediaOptions = JSON.JsonHelper.Deserialize<MediaOptions>(options);
      Commands\Notification.cs(92): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);
      Commands\Notification.cs(123): AlertOptions alertOpts = JSON.JsonHelper.Deserialize<AlertOptions>(options);

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            purplecabbage Jesse MacFadyen
            purplecabbage Jesse MacFadyen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment