Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10773

Incorrect path separator in FRAMEWORK_SEARCH_PATHS with custom framework from plugin.xml

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1.1
    • Component/s: cordova-ios
    • Environment:

      iOS

      Description

      When an iOS project is created and a plugin with custom frameworks is added on Windows, the path separator in FRAMEWORK_SEARCH_PATHS of the pbxproj file is incorrect. It has the Windows path separator. This causes build issues when the project is moved to OSX and built in Xcode.

      This is ultimately coming from the xcode npm package. I have opened up an issue with that module with a suggested solution: https://github.com/alunny/node-xcode/issues/80

      Once it is fixed there, we will need to refresh our version of the xcode npm package in our node_modules for cordova-ios

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d1199065289c37bbaee91dceca84f78ff73b064e in cordova-ios's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=d119906 ]

          CB-10773 Update path delimiters in tests

          Show
          jira-bot ASF subversion and git services added a comment - Commit d1199065289c37bbaee91dceca84f78ff73b064e in cordova-ios's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=d119906 ] CB-10773 Update path delimiters in tests
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-ios/pull/201

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/201
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit af5a5d86059d68d5011c557c215a0d785620453d in cordova-ios's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=af5a5d8 ]

          CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32

          This closes #201

          Show
          jira-bot ASF subversion and git services added a comment - Commit af5a5d86059d68d5011c557c215a0d785620453d in cordova-ios's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=af5a5d8 ] CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32 This closes #201
          Show
          vladimir.kotikov Vladimir Kotikov added a comment - Please also see https://github.com/alunny/node-xcode/pull/81/files
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-ios/pull/201

          CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32

          This is a fix https://issues.apache.org/jira/browse/CB-10773
          Similar PR to `node-xcode`: https://github.com/alunny/node-xcode/pull/81/files

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-ios CB-10773

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-ios/pull/201.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #201


          commit 5dd92a61b20e81ee5c98287b3173ee61d93a07c5
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2016-03-05T10:22:10Z

          CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/201 CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32 This is a fix https://issues.apache.org/jira/browse/CB-10773 Similar PR to `node-xcode`: https://github.com/alunny/node-xcode/pull/81/files You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-10773 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #201 commit 5dd92a61b20e81ee5c98287b3173ee61d93a07c5 Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2016-03-05T10:22:10Z CB-10773 Correct FRAMEWORKS_SEARCH_PATHS on win32
          Hide
          nikhilkh Nikhil Khandelwal added a comment -

          We need this fixed soon - Vladimir Kotikov can you please propose a PR for this issue?

          Show
          nikhilkh Nikhil Khandelwal added a comment - We need this fixed soon - Vladimir Kotikov can you please propose a PR for this issue?

            People

            • Assignee:
              vladimir.kotikov Vladimir Kotikov
              Reporter:
              eymorale Edna Morales
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development