Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10438

Plugin dependency version/spec is not used/ignored

Details

    Description

      Quite the bug!

      <dependency id="cordova-plugin-file" spec="3.0.0" />
      or
      <dependency id="cordova-plugin-file" version="3.0.0" />
      

      The above line will ignore spec or version and will always grab the latest. I went back and tried the previous version of cordova and this seems to be ignoring it as well. Seems like this was never working.

      Attachments

        Issue Links

          Activity

            Phew! How did this get broken - we need more tests!

            nikhilkh Nikhil Khandelwal added a comment - Phew! How did this get broken - we need more tests!
            tony-- Tony Homer added a comment -

            Well, this explains some weird behavior I've seen before. I didn't realize this was the root cause, although it's obvious in retrospect. FWIW a workaround that might be useful in some cases is to get the dependency from a repo instead of npm.

            <dependency id="cordova-plugin-crosswalk-webview" url="https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview#1.4.0" />
            

            This is slower, but if you really need a specific version you can get it this way.

            tony-- Tony Homer added a comment - Well, this explains some weird behavior I've seen before. I didn't realize this was the root cause, although it's obvious in retrospect. FWIW a workaround that might be useful in some cases is to get the dependency from a repo instead of npm. <dependency id= "cordova-plugin-crosswalk-webview" url= "https: //github.com/crosswalk-project/cordova-plugin-crosswalk-webview#1.4.0" /> This is slower, but if you really need a specific version you can get it this way.
            githubbot ASF GitHub Bot added a comment -

            GitHub user carynbear opened a pull request:

            https://github.com/apache/cordova-lib/pull/455

            CB-10438 Install correct dependency version, requires force to instal…

            …l plugin with wrong dependency version installed

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/carynbear/cordova-lib CB-10438

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-lib/pull/455.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #455


            commit 2973f30779cb2c32140381d91e9b09d41ded6a86
            Author: carynbear <caryn.tran@berkeley.edu>
            Date: 2016-06-07T00:21:02Z

            CB-10438 Install correct dependency version, requires force to install plugin with wrong dependency version installed


            githubbot ASF GitHub Bot added a comment - GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/455 CB-10438 Install correct dependency version, requires force to instal… …l plugin with wrong dependency version installed You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-lib CB-10438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/455.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #455 commit 2973f30779cb2c32140381d91e9b09d41ded6a86 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-07T00:21:02Z CB-10438 Install correct dependency version, requires force to install plugin with wrong dependency version installed
            githubbot ASF GitHub Bot added a comment -

            Github user codecov-io commented on the issue:

            https://github.com/apache/cordova-lib/pull/455

              1. [Current coverage][cc-pull] is *80.56%*
                > Merging 455[cc-pull] into [master][cc-base-branch] will increase coverage by *0.05%*

            ```diff
            @@ master #455 diff @@
            ==========================================
            Files 68 68
            Lines 5389 5403 +14
            Methods 851 851
            Messages 0 0
            Branches 1043 1051 +8
            ==========================================
            + Hits 4339 4353 +14
            Misses 1050 1050
            Partials 0 0
            ```

            > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d28eed6...2973f30][cc-compare]
            [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
            [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/d28eed638544ed7a52b77dedaef077a0ac450cb5...2973f30779cb2c32140381d91e9b09d41ded6a86
            [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/455?src=pr

            githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/455 [Current coverage] [cc-pull] is * 80.56% * > Merging 455 [cc-pull] into [master] [cc-base-branch] will increase coverage by * 0.05% * ```diff @@ master #455 diff @@ ========================================== Files 68 68 Lines 5389 5403 +14 Methods 851 851 Messages 0 0 Branches 1043 1051 +8 ========================================== + Hits 4339 4353 +14 Misses 1050 1050 Partials 0 0 ``` > Powered by [Codecov] ( https://codecov.io?src=pr ). Last updated by [d28eed6...2973f30] [cc-compare] [cc-base-branch] : https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr [cc-compare] : https://codecov.io/gh/apache/cordova-lib/compare/d28eed638544ed7a52b77dedaef077a0ac450cb5...2973f30779cb2c32140381d91e9b09d41ded6a86 [cc-pull] : https://codecov.io/gh/apache/cordova-lib/pull/455?src=pr
            githubbot ASF GitHub Bot added a comment -

            Github user carynbear commented on the issue:

            https://github.com/apache/cordova-lib/pull/455

            @stevengill bump

            githubbot ASF GitHub Bot added a comment - Github user carynbear commented on the issue: https://github.com/apache/cordova-lib/pull/455 @stevengill bump
            githubbot ASF GitHub Bot added a comment -

            GitHub user audreyso opened a pull request:

            https://github.com/apache/cordova-lib/pull/527

            CB-10438 : Install correct dependency version

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                1. What does this PR do?
                  Install correct dependency version, requires force to install plugin with wrong dependency version installed.
                1. What testing has been done on this change?
                1. Checklist
            • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
            • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
            • [X] Added automated test coverage as appropriate for this change.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/audreyso/cordova-lib CB-10438

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-lib/pull/527.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #527


            commit 99c0527ad221ae8cd92cf955da81250b2cc95022
            Author: carynbear <caryn.tran@berkeley.edu>
            Date: 2016-06-07T00:21:02Z

            CB-10438 Install correct dependency version, requires force to install plugin with wrong dependency version installed

            commit f2c57e5f8453c1c5bc7c8bddf241bc34c34c39ec
            Author: Audrey So <audreyso@apache.org>
            Date: 2017-03-10T18:23:17Z

            CB-10438 : updated install.spec test to work with jasmine 2.0

            commit d08d3081613d7ff9af758c8a01d8aeeed7ebf6c8
            Author: Audrey So <audreyso@apache.org>
            Date: 2017-03-13T17:43:04Z

            CB-10438 : removed shell.remove because it was deleting dummy plugin tests and not able to recreate them and updated C@1.0.0 id in tests, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js


            githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/527 CB-10438 : Install correct dependency version <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Install correct dependency version, requires force to install plugin with wrong dependency version installed. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-10438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #527 commit 99c0527ad221ae8cd92cf955da81250b2cc95022 Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-07T00:21:02Z CB-10438 Install correct dependency version, requires force to install plugin with wrong dependency version installed commit f2c57e5f8453c1c5bc7c8bddf241bc34c34c39ec Author: Audrey So <audreyso@apache.org> Date: 2017-03-10T18:23:17Z CB-10438 : updated install.spec test to work with jasmine 2.0 commit d08d3081613d7ff9af758c8a01d8aeeed7ebf6c8 Author: Audrey So <audreyso@apache.org> Date: 2017-03-13T17:43:04Z CB-10438 : removed shell.remove because it was deleting dummy plugin tests and not able to recreate them and updated C@1.0.0 id in tests, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js
            githubbot ASF GitHub Bot added a comment -

            Github user codecov-io commented on the issue:

            https://github.com/apache/cordova-lib/pull/527

            1. [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=h1) Report
              > Merging 527(https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc) will *increase* coverage by `0.02%`.
              > The diff coverage is `94.44%`.

            ```diff
            @@ Coverage Diff @@

              1. master #527 +/- ##
                ==========================================
                + Coverage 81.9% 81.92% +0.02%
                ==========================================
                Files 68 68
                Lines 5498 5516 +18
                Branches 1090 1099 +9
                ==========================================
                + Hits 4503 4519 +16
            • Misses 995 997 +2
              ```

            ------

            [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=continue).
            > *Legend* - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
            > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
            > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=footer). Last update [07001dc...a725a79](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...a725a79ca79c83561055a535bcdd7c848e69d01d?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

            githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/527 [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=h1 ) Report > Merging 527 ( https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=desc ) into [master] ( https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc ) will * increase * coverage by `0.02%`. > The diff coverage is `94.44%`. ```diff @@ Coverage Diff @@ master #527 +/- ## ========================================== + Coverage 81.9% 81.92% +0.02% ========================================== Files 68 68 Lines 5498 5516 +18 Branches 1090 1099 +9 ========================================== + Hits 4503 4519 +16 Misses 995 997 +2 ``` [Impacted Files] ( https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=tree ) Coverage Δ   — — — [cordova-lib/src/plugman/plugman.js] ( https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGx1Z21hbi5qcw== ) `28.44% <0%> (-0.27%)` :x: [cordova-lib/src/plugman/install.js] ( https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw== ) `87.85% <100%> (+0.69%)` :white_check_mark: [cordova-lib/src/platforms/PlatformApiPoly.js] ( https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM= ) `93.79% <0%> (-0.39%)` :x: ------ [Continue to review full report at Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=continue ). > * Legend * - [Click here to learn more] ( https://docs.codecov.io/docs/codecov-delta ) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=footer ). Last update [07001dc...a725a79] ( https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...a725a79ca79c83561055a535bcdd7c848e69d01d?el=footer&src=pr&el=lastupdated ). Read the [comment docs] ( https://docs.codecov.io/docs/pull-request-comments ).
            githubbot ASF GitHub Bot added a comment -

            Github user audreyso commented on the issue:

            https://github.com/apache/cordova-lib/pull/527

            Rebased after CB-11346 was merged in.

            githubbot ASF GitHub Bot added a comment - Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/527 Rebased after CB-11346 was merged in.
            githubbot ASF GitHub Bot added a comment -

            Github user audreyso closed the pull request at:

            https://github.com/apache/cordova-lib/pull/527

            githubbot ASF GitHub Bot added a comment - Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/527
            githubbot ASF GitHub Bot added a comment -

            GitHub user audreyso opened a pull request:

            https://github.com/apache/cordova-lib/pull/530

            CB-10438 : Install correct dependency version

            requires force to install plugin with wrong dependency version installed.

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                1. What does this PR do?
                  Install correct dependency version.
                  Requires force to install plugin with wrong dependency version installed.
                1. What testing has been done on this change?
                1. Checklist
            • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
            • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
            • [X] Added automated test coverage as appropriate for this change.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/audreyso/cordova-lib CB-10438

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-lib/pull/530.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #530


            commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a
            Author: carynbear <caryn.tran@berkeley.edu>
            Date: 2016-06-07T00:21:02Z

            CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0


            githubbot ASF GitHub Bot added a comment - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/530 CB-10438 : Install correct dependency version requires force to install plugin with wrong dependency version installed. <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Install correct dependency version. Requires force to install plugin with wrong dependency version installed. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-10438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #530 commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-07T00:21:02Z CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0
            githubbot ASF GitHub Bot added a comment -

            Github user audreyso commented on the issue:

            https://github.com/apache/cordova-lib/pull/530

            Rebased after CB-11346 was merged in.

            githubbot ASF GitHub Bot added a comment - Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/530 Rebased after CB-11346 was merged in.
            githubbot ASF GitHub Bot added a comment -

            Github user audreyso closed the pull request at:

            https://github.com/apache/cordova-lib/pull/530

            githubbot ASF GitHub Bot added a comment - Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/530
            githubbot ASF GitHub Bot added a comment -

            GitHub user audreyso reopened a pull request:

            https://github.com/apache/cordova-lib/pull/530

            CB-10438 : Install correct dependency version

            requires force to install plugin with wrong dependency version installed.

            <!--
            Please make sure the checklist boxes are all checked before submitting the PR. The checklist
            is intended as a quick reference, for complete details please see our Contributor Guidelines:

            http://cordova.apache.org/contribute/contribute_guidelines.html

            Thanks!
            -->

                1. Platforms affected
                1. What does this PR do?
                  Install correct dependency version.
                  Requires force to install plugin with wrong dependency version installed.
                1. What testing has been done on this change?
                1. Checklist
            • [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
            • [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
            • [X] Added automated test coverage as appropriate for this change.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/audreyso/cordova-lib CB-10438

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-lib/pull/530.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #530


            commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a
            Author: carynbear <caryn.tran@berkeley.edu>
            Date: 2016-06-07T00:21:02Z

            CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0


            githubbot ASF GitHub Bot added a comment - GitHub user audreyso reopened a pull request: https://github.com/apache/cordova-lib/pull/530 CB-10438 : Install correct dependency version requires force to install plugin with wrong dependency version installed. <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Platforms affected What does this PR do? Install correct dependency version. Requires force to install plugin with wrong dependency version installed. What testing has been done on this change? Checklist [X] [Reported an issue] ( http://cordova.apache.org/contribute/issues.html ) in the JIRA database [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-lib CB-10438 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #530 commit 06ebb7516976370e9a4322b12cca5c79f89a5a2a Author: carynbear <caryn.tran@berkeley.edu> Date: 2016-06-07T00:21:02Z CB-10438 :Install correct dependency version, requires force to install plugin with wrong dependency version installed. Also, removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0
            githubbot ASF GitHub Bot added a comment -

            Github user codecov-io commented on the issue:

            https://github.com/apache/cordova-lib/pull/530

            1. [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=h1) Report
              > Merging 530(https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/da952e074d36bd917beb041dc4e49abc760f5561?src=pr&el=desc) will *increase* coverage by `0.04%`.
              > The diff coverage is `95.45%`.

            ```diff
            @@ Coverage Diff @@

              1. master #530 +/- ##
                ==========================================
                + Coverage 82.13% 82.17% +0.04%
                ==========================================
                Files 68 68
                Lines 5498 5516 +18
                Branches 1087 1096 +9
                ==========================================
                + Hits 4516 4533 +17
            • Misses 982 983 +1
              ```

            ------

            [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=continue).
            > *Legend* - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
            > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
            > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=footer). Last update [da952e0...06ebb75](https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

            githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/530 [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=h1 ) Report > Merging 530 ( https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=desc ) into [master] ( https://codecov.io/gh/apache/cordova-lib/commit/da952e074d36bd917beb041dc4e49abc760f5561?src=pr&el=desc ) will * increase * coverage by `0.04%`. > The diff coverage is `95.45%`. ```diff @@ Coverage Diff @@ master #530 +/- ## ========================================== + Coverage 82.13% 82.17% +0.04% ========================================== Files 68 68 Lines 5498 5516 +18 Branches 1087 1096 +9 ========================================== + Hits 4516 4533 +17 Misses 982 983 +1 ``` [Impacted Files] ( https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=tree ) Coverage Δ   — — — [cordova-lib/src/plugman/plugman.js] ( https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGx1Z21hbi5qcw== ) `28.44% <0%> (-0.27%)` :arrow_down: [cordova-lib/src/plugman/install.js] ( https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw== ) `87.78% <100%> (+0.7%)` :arrow_up: ------ [Continue to review full report at Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=continue ). > * Legend * - [Click here to learn more] ( https://docs.codecov.io/docs/codecov-delta ) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov] ( https://codecov.io/gh/apache/cordova-lib/pull/530?src=pr&el=footer ). Last update [da952e0...06ebb75] ( https://codecov.io/gh/apache/cordova-lib/compare/da952e074d36bd917beb041dc4e49abc760f5561...06ebb7516976370e9a4322b12cca5c79f89a5a2a?el=footer&src=pr&el=lastupdated ). Read the [comment docs] ( https://docs.codecov.io/docs/pull-request-comments ).

            Commit fd6b9dd45e5f9fa8f6e7d7bfa28b9a4183882b2b in cordova-lib's branch refs/heads/master from carynbear
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fd6b9dd ]

            CB-10438 :Install correct dependency version. Removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0

            This closes #530, this closes #455

            jira-bot ASF subversion and git services added a comment - Commit fd6b9dd45e5f9fa8f6e7d7bfa28b9a4183882b2b in cordova-lib's branch refs/heads/master from carynbear [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fd6b9dd ] CB-10438 :Install correct dependency version. Removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0 This closes #530, this closes #455
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-lib/pull/530

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/530
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-lib/pull/455

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/455
            githubbot ASF GitHub Bot added a comment -

            Github user stevengill commented on the issue:

            https://github.com/apache/cordova-lib/pull/530

            merged

            githubbot ASF GitHub Bot added a comment - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/530 merged

            Commit fd6b9dd45e5f9fa8f6e7d7bfa28b9a4183882b2b in cordova-lib's branch refs/heads/common-2.0.x from carynbear
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fd6b9dd ]

            CB-10438 :Install correct dependency version. Removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0

            This closes #530, this closes #455

            jira-bot ASF subversion and git services added a comment - Commit fd6b9dd45e5f9fa8f6e7d7bfa28b9a4183882b2b in cordova-lib's branch refs/heads/common-2.0.x from carynbear [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=fd6b9dd ] CB-10438 :Install correct dependency version. Removed shell.remove, added pkg.json to dependency tests 1-3, and updated install.js (.replace) to fix tests in uninstall.spec.js and update to workw with jasmine 2.0 This closes #530, this closes #455

            People

              stevegill Steve Gill
              stevegill Steve Gill
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: