Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10412

[iOS — 3.x.x] AutoHideSplashScreen "false" isn't taken in account

Details

    Description

      if your set AutoHideSplashScreen to false in order to hide it yourself later via #hide() method, the splashscreen on iOS never disappear.

      <preference name="AutoHideSplashScreen" value="false"/>

      AutoHideSplashScreen works fine if set to true.

      Tried with $cordovaSplashscreen from ngCordova and navigator.splashscreen directly.

      Attachments

        Issue Links

          Activity

            jean.dat@gmail.com, does this reproduce with cordova-plugin-splashscreen?

            cordova plugin add http://github.com/apache/cordova-plugin-splashscreen
            
            daserge Sergey Shakhnazarov added a comment - jean.dat@gmail.com , does this reproduce with cordova-plugin-splashscreen ? cordova plugin add http: //github.com/apache/cordova-plugin-splashscreen
            jean.dat@gmail.com jdat82 added a comment -

            Yes. Same thing.

            jean.dat@gmail.com jdat82 added a comment - Yes. Same thing.

            jean.dat@gmail.com, the issue does not reproduce for me on ios@3.9.2 and cordova-plugin-splashscreen@3.1.0 and cordova-plugin-splashscreen@3.0.0.

            Could you please provide some repro steps or test solution?

            daserge Sergey Shakhnazarov added a comment - jean.dat@gmail.com , the issue does not reproduce for me on ios@3.9.2 and cordova-plugin-splashscreen@3.1.0 and cordova-plugin-splashscreen@3.0.0. Could you please provide some repro steps or test solution?
            jean.dat@gmail.com jdat82 added a comment -

            Found out you can't have both:

            <preference name="AutoHideSplashScreen" value="false"/>
            <preference name="SplashScreenDelay" value="5000"/>

            It needs to be either:
            <preference name="AutoHideSplashScreen" value="true"/>
            <preference name="SplashScreenDelay" value="5000"/>
            OR
            <preference name="AutoHideSplashScreen" value="false"/>

            Which is logic of course but still, SplashScreenDelay should be ignored when AutoHideSplashScreen is false because it doesn't make sense.
            I think its still a bug.

            Thanks.

            jean.dat@gmail.com jdat82 added a comment - Found out you can't have both: <preference name="AutoHideSplashScreen" value="false"/> <preference name="SplashScreenDelay" value="5000"/> It needs to be either: <preference name="AutoHideSplashScreen" value="true"/> <preference name="SplashScreenDelay" value="5000"/> OR <preference name="AutoHideSplashScreen" value="false"/> Which is logic of course but still, SplashScreenDelay should be ignored when AutoHideSplashScreen is false because it doesn't make sense. I think its still a bug. Thanks.
            githubbot ASF GitHub Bot added a comment -

            GitHub user daserge opened a pull request:

            https://github.com/apache/cordova-plugin-splashscreen/pull/78

            CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS

            [Jira issue](https://issues.apache.org/jira/browse/CB-10412)

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-10412

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-splashscreen/pull/78.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #78


            commit 10f9de50bfec6780d594c4a6db7a56e7e3a483fb
            Author: daserge <v-seshak@microsoft.com>
            Date: 2016-01-26T10:21:42Z

            CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS


            githubbot ASF GitHub Bot added a comment - GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/78 CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS [Jira issue] ( https://issues.apache.org/jira/browse/CB-10412 ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-10412 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit 10f9de50bfec6780d594c4a6db7a56e7e3a483fb Author: daserge <v-seshak@microsoft.com> Date: 2016-01-26T10:21:42Z CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS

            jean.dat@gmail.com, thanks, I've submitted a fix for this issue.

            daserge Sergey Shakhnazarov added a comment - jean.dat@gmail.com , thanks, I've submitted a fix for this issue.

            Commit 109c82b29b6cfda4fabcd0aa9a7660954b50e7d6 in cordova-plugin-splashscreen's branch refs/heads/master from daserge
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=109c82b ]

            CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS

            jira-bot ASF subversion and git services added a comment - Commit 109c82b29b6cfda4fabcd0aa9a7660954b50e7d6 in cordova-plugin-splashscreen's branch refs/heads/master from daserge [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=109c82b ] CB-10412 AutoHideSplashScreen "false" isn't taken in account on iOS
            githubbot ASF GitHub Bot added a comment -

            Github user daserge commented on the pull request:

            https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-175708006

            Merged via 109c82b29b6cfda4fabcd0aa9a7660954b50e7d6

            githubbot ASF GitHub Bot added a comment - Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-175708006 Merged via 109c82b29b6cfda4fabcd0aa9a7660954b50e7d6
            githubbot ASF GitHub Bot added a comment -

            Github user daserge closed the pull request at:

            https://github.com/apache/cordova-plugin-splashscreen/pull/78

            githubbot ASF GitHub Bot added a comment - Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/78

            Fixed in 3.1.1-dev

            daserge Sergey Shakhnazarov added a comment - Fixed in 3.1.1-dev
            githubbot ASF GitHub Bot added a comment -

            Github user bitflower commented on the pull request:

            https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-182047128

            I picked the latest 3.2.1-dev because of this bug and now I get XCode memory errors when running an app in debug mode. If started normally on the device it runs fine. Could this be due to this commit?

            githubbot ASF GitHub Bot added a comment - Github user bitflower commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/78#issuecomment-182047128 I picked the latest 3.2.1-dev because of this bug and now I get XCode memory errors when running an app in debug mode. If started normally on the device it runs fine. Could this be due to this commit?
            bitflower Matthias Max added a comment - The bug is also there in production, see my comment here: https://issues.apache.org/jira/browse/CB-10562?focusedCommentId=15141388&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15141388
            bitflower Matthias Max added a comment -

            EDIT to my github comment: The memory leak also appears on the device when not in debug mode with XCode.

            bitflower Matthias Max added a comment - EDIT to my github comment: The memory leak also appears on the device when not in debug mode with XCode.

            People

              Unassigned Unassigned
              jean.dat@gmail.com jdat82
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: