[CB-10314] avoid fetching newId when oldId is already fetched

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: cordova-lib
• Labels: triaged
• Assignee: Byoungro So
• Reporter: Byoungro So
• Created: 10/Jan/16 23:43
• Updated: 03/May/17 07:20
• Resolved: 05/Mar/16 18:55

Description

As of Cordova 5.4.0, an old plugin id is automatically converted to a new id using the corodva-registry-mapper.
This causes a new id to be fetched even if an old id is already fetched in the plugins directory (at cordova-lib/src/plugman/install.js)
However, plugman/fetch.js/copyPlugin() checks if the alias id is already in the plugins directory, and skips installing the fetched newId plugin.
This causes unnecessary overhead.
It is better to check if the oldId is already fetched, and skips fetching the newId from the beginning.

[t6.0.1] cordova plugins
cordova-plugin-whitelist 1.2.1 "Whitelist"
org.apache.cordova.device 0.3.0 "Device"
[t6.0.1] cordova plugin add org.apache.cordova.device
Notice: org.apache.cordova.device has been automatically converted to cordova-plugin-device to be fetched from npm. This is due to our old plugins registry shutting down.
Fetching plugin "cordova-plugin-device" via npm
cordova-plugin-device" will not install due to "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being installed.
Notice: org.apache.cordova.device has been automatically converted to cordova-plugin-device and fetched from npm. This is due to our old plugins registry shutting down.
Fetching plugin "cordova-plugin-device" via npm
cordova-plugin-device" will not install due to "/Users/bso/cordova/test/t6.0.1/plugins/org.apache.cordova.device" being installed.
Plugin "org.apache.cordova.device" already installed on ios.