Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10284

Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Invalid
    • 5.4.0, 5.4.1
    • None
    • cordova-lib
    • Mac OS X 10.10.5

    Description

      Using Cordova CLI 5.3.3, try creating a new project and then adding the Android platform and the whitelist plugin (using `$ cordova plugin add cordova-plugin-whitelist@1.2.0`). Then open the plugins/android.json file, its content is:

      plugins/android.json
      {
          "prepare_queue": {
              "installed": [],
              "uninstalled": []
          },
          "config_munge": {
              "files": {
                  "res/xml/config.xml": {
                      "parents": {
                          "/*": [
                              {
                                  "xml": "<feature name=\"Whitelist\"><param name=\"android-package\" value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /><param name=\"onload\" value=\"true\" /></feature>",
                                  "count": 1
                              }
                          ]
                      }
                  }
              }
          },
          "installed_plugins": {
              "cordova-plugin-whitelist": {
                  "PACKAGE_NAME": "com.my-app.dev"
              }
          },
          "dependent_plugins": {}
      }
      

      Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same exact thing. The file content is:

      plugins/android.json
      {
          "prepare_queue": {
              "installed": [],
              "uninstalled": []
          },
          "config_munge": {
              "files": {}
          },
          "installed_plugins": {
              "cordova-plugin-whitelist": {
                  "PACKAGE_NAME": "com.my-app.dev"
              }
          },
          "dependent_plugins": {}
      }
      

      Notice that `config_munge.files` is empty. This is a major regression as plugins using this feature don't work at all sometimes even preventing the `deviceready` event to be triggered.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              SebastienP Sebastien
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: