[CB-10088] filetransfer spec.10 and spec.11 test is faulty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-plugin-file-transfer (DEPRECATED)
• Labels: iOS

Environment

Xcode 7.1
iOS 9.1 iPhone 6s

• Assignee: Shazron Abdullah
• Reporter: Shazron Abdullah
• Created: 26/Nov/15 07:03
• Updated: 23/Aug/18 07:08
• Resolved: 26/Nov/15 21:46

Description

Copied from:
https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283

This is within the context of mobile-spec's autotests.

I added some logs in the native code, and cordova-filetransfer.tests spec.10's file "downloaded" within 30ms (probably because of caching). When calling abort, there is no active file transfer so the failure callback is not called back to JavaScript:
https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380

Since the failure callback is never called (the abort), and the the unexpected download success was called, the test fails.

The test is faulty and needs to be reworked to take into account this case, where the download finished before the file could be aborted (the test delays the abort call).

Issue Links

• blocks: CB-10082 [UIWebView][iOS 9] Failing tests on mobile-spec
• is related to: CB-10098 filetransfer.spec.33 is faulty
• relates to: CB-8641 (Windows Phone 8.1) Some file-transfer plugin tests occasionally fail in mobilespec