Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-10006 Handle <allow-navigation> and <allow-intent>
  3. CB-10025

CDVWhiteList can't parse URIs that don't have double slashes after the scheme

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      e.g

      tel:1234567890
      name@example.com

      Separate the parsing behaviour so it is testable. Then, add failing tests first, then fix it.

      Future:
      Replace regex parsing with just NSURL, then parse the wildcard bits explicitly for items that cannot be parsed. This is more readable and maintanable. Doubt there are any significant speedups with regex here anyway since URL loading in Cordova through links are not time sensitive (since gap: urls are not put through the whitelist).

      Only anchor tag links are put through the whitelist with the new re-factor (further processed whether they are <allow-intent> and <allow-navigation>, everything else is loaded by the webview.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shazron Shazron Abdullah
                Reporter:
                shazron Shazron Abdullah
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: