Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-100

fix issues regarding pre-req licenses for weinre distribution

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: weinre
    • Labels:
      None

      Description

      weinre is currently distributed as two binary wads - a .jar file and a Mac .app file (which includes the .jar file and other pieces of goo). The wads are built from a combination of weinre code which will eventually be housed at Apache, as well as various dependencies which are currently retrieved from other repositories as part of the build process.

      Those pre-reqs are:

      • Files from modjewel. CommonJS runtime for the browser. License: MIT
      • Files from Apache Commons CLI. Command-line parser. License: ASLv2
      • Files from Apache Wink. JSON codecs. License: ASLv2
      • Files from WebKit. Web Inspector code. Although WebKit in general contains both BSD and LGPL code, only BSD licensed code is used by weinre.
      • Files from Eclipse Jetty. HTTP server. License: ASLv2 and EPLv1
      • Files from Eclipse SWT. Platform UI toolkit. License: EPLv1

      As we look at being able to make weinre downloads available at Apache, we need to follow the guidelines associated with shipping 3rd party code. There's a handy FAQ on this, here:

      http://apache.org/legal/resolved.html#category-a

      Some notes then, on the subject pre-reqs:

      • Files from modjewel. This is actually my code; I'll pull it into weinre directly and relicense as ASL. I pulled one request from another developer into modjewel, but this was for an npm package.json, which I will be removing as that's no longer applicable. It may be that by the time I'm ready to pull this code in, we may have a different module library available for cordova proper, which I would likely reuse (no matter what it is). So, no problem with this.
      • Files from Apache Commons CLI. Command-line parser. License: ASLv2. Shouldn't be a problem.
      • Files from Apache Wink. JSON codecs. License: ASLv2. Shouldn't be a problem.
      • Files from WebKit. Web Inspector code. Although WebKit in general contains both BSD and LGPL code, only BSD licensed code is used by weinre. I looked through all of the WebKit files that I package into the distribution, and they're all BSD 2 clause or 3 clause variants with no advertising clause. So that looks good. Unfortunately, this will need to be checked whenever we decide to pull new versions of the Web Inspector code. There is currently a code-scan to check for GPL licenses, which should be expanded to search for the BSD advertising clause as well. But we'll really need to eyeball the individual files anyway whenever we pull a new version. Sigh.
      • Files from Eclipse Jetty. HTTP server. License: ASLv2 and EPLv1. Not sure how much of a problem this, since some version of Jetty is licensed ASLv2. The issue with Jetty would be moot if we decide to port the server to node.js. Note the idea would be to make node.js a runtime pre-req, just like java vm's are for other Apache java projects, so we wouldn't actually be shipping node.js. Have a bit of time to noodle over what to do here.
      • Files from Eclipse SWT. Platform UI toolkit. License: EPLv1. I think this is a huge problem. EPL is not a license we can reship with. EDL is, but as near as I can tell, the Eclipse SWT code is not EDL. To make matters worse, SWT tends to ship other licensed code itself; the Mac SWT code I currently ship contains MPL code, for instance. My current thought on this is to just stop building and shipping the "Mac app" version of weinre - we'd just ship the "jar file" version (or a node.js version). I'll leave all the existing code where it is - it's all mine and so can be licensed ASL, but just won't build or ship it. There's likely a happy ending to this issue though - Apache allows some non-Apache licensed code to be reshipped as binary only. Something to investigate later.

        Activity

        Hide
        pmuellr Patrick Mueller added a comment -

        Most of the bullet points of this issue have already been resolved in the commit for https://issues.apache.org/jira/browse/CB-176 .

        Current state is that Jukka reviewed the LICENSE and NOTICE files, and gave the following comments via email:

        The only improvement I'd like to see is spelling out the exact license
        conditions of the BSD licenses of the WebKit inspector code included
        in weinre (now the LICENSE just references the "BSD license").
        
        A quick browsing of the various license headers suggests the following
        copyright notices and a BSD license with the explicit conditions on
        not using Google's or Apple's name to endorse or promote derived
        products should be included in our LICENSE file.
        
            Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc.  All rights reserved.
            Copyright (C) 2007, 2008 Matt Lilek (pewt...@gmail.com / web...@mattlilek.com)
            Copyright (C) 2008, 2009 Anthony Ricaud <ri...@webkit.org>
            Copyright (C) 2008 Nokia Inc.  All rights reserved.
            Copyright (C) 2009 IBM Corp.  All rights reserved.
            Copyright (C) 2009 Anthony Ricaud <ri...@webkit.org>
            Copyright (C) 2009, 2010, 2011 Google Inc.  All rights reserved.
            Copyright (C) 2009, 2010 Joseph Pecoraro. All rights reserved.
            Copyright (C) 2009 280 North Inc.  All Rights Reserved.
            Copyright (C) 2010 Nikita Vasilyev. All rights reserved.
        
        The LICENSE entry for the formidable library should preferably say
        something like:
        
            According to the Readme.md file in the Formidable library:
            "Formidable is licensed under the MIT license."
        
        That makes it clearer that this is the only explicit license
        information included in the library. We might want to ask the
        maintainer of this library to add an explicit LICENSE file which
        explicitly spells out the MIT license terms and records the actual
        copyright holder who's granting that license. Otherwise the above
        reference is a bit vague (though AFAICT good enough for us for now).
        
        Show
        pmuellr Patrick Mueller added a comment - Most of the bullet points of this issue have already been resolved in the commit for https://issues.apache.org/jira/browse/CB-176 . Current state is that Jukka reviewed the LICENSE and NOTICE files, and gave the following comments via email : The only improvement I'd like to see is spelling out the exact license conditions of the BSD licenses of the WebKit inspector code included in weinre (now the LICENSE just references the "BSD license"). A quick browsing of the various license headers suggests the following copyright notices and a BSD license with the explicit conditions on not using Google's or Apple's name to endorse or promote derived products should be included in our LICENSE file. Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. Copyright (C) 2007, 2008 Matt Lilek (pewt...@gmail.com / web...@mattlilek.com) Copyright (C) 2008, 2009 Anthony Ricaud <ri...@webkit.org> Copyright (C) 2008 Nokia Inc. All rights reserved. Copyright (C) 2009 IBM Corp. All rights reserved. Copyright (C) 2009 Anthony Ricaud <ri...@webkit.org> Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved. Copyright (C) 2009, 2010 Joseph Pecoraro. All rights reserved. Copyright (C) 2009 280 North Inc. All Rights Reserved. Copyright (C) 2010 Nikita Vasilyev. All rights reserved. The LICENSE entry for the formidable library should preferably say something like: According to the Readme.md file in the Formidable library: "Formidable is licensed under the MIT license." That makes it clearer that this is the only explicit license information included in the library. We might want to ask the maintainer of this library to add an explicit LICENSE file which explicitly spells out the MIT license terms and records the actual copyright holder who's granting that license. Otherwise the above reference is a bit vague (though AFAICT good enough for us for now).
        Show
        pmuellr Patrick Mueller added a comment - fixes in commit https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-weinre.git;a=commit;h=2598e97f6db7a6d6dc2d667fbaf0045faf705e54

          People

          • Assignee:
            pmuellr Patrick Mueller
            Reporter:
            pmuellr Patrick Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development