[CAY-817] HSQLDB schema generation may not correctly flush the changes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2 branch, 2.0 branch, 3.0
• Fix Version/s: 3.0M1
• Component/s: Core Library, Modeler
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 29/Jun/07 10:57
• Updated: 09/Nov/08 01:14
• Resolved: 29/Jun/07 11:12

Description

When investigating CAY-790, I noticed that our own code is prone to HSQLDB problem with not flushing changes to disk immediately. When the Modeler (or I believe the Ant task) generates schema, nothing may get generated. I tried adding the following code to the Modeler and it seems to solve to problem (only instead of "SHUTDOWN" it issues "CHECKPOINT"):

if (connectionInfo.getUrl().startsWith("jdbc:hsqldb:file:")) {
Connection c = dataSource.getConnection();
try {
PreparedStatement st = c.prepareStatement("CHECKPOINT");
try

{ st.execute(); }

finally

{ st.close(); }

}
finally

{ c.close(); }

}

Since DbAdapter does not provides API for "post-generation processing" of the DB, I guess I'll add db-specific handlers straight into the DbGenerator, that would detect a DB type using DbAdapterFactory.