[CAY-685] OSQueryCache concurrency improvements

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 3.0M1, 3.0
• Component/s: Core Library
• Assignee: Unassigned
• Reporter: Andrus Adamchik
• Created: 10/Oct/06 20:21
• Updated: 08/May/10 15:41
• Resolved: 11/Oct/06 22:53

Description

OSQueryCache.get(QueryMetadata) exits immediately on cache miss, returning null, instead of filling the cache per advice given here:

http://wiki.opensymphony.com/display/CACHE/API+Usage

This works, but results in poor concurrency - if multiple threads run the same query simultaneously, the query will be executed multiple times, with last returning thread overriding the cache, so cache entry expiration results in spike of activity on a loaded server...

To fix this we may need to reengineer the query pipeline (pass a "result factory" object to the cache, so that the query can be executed inside the cache provider).

Issue Links

• is related to: CAY-613 Pluggable Query Cache