[CAY-2804] LocalTimeValueType potential loss of precision

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.2.RC2
• Fix Version/s: 5.0-M1
• Assignee: Nikita Timofeev
• Reporter: Andrus Adamchik
• Created: 19/Mar/23 18:59
• Updated: 19/May/23 07:28

Description

I just ran into a problem (outside Cayenne) when conversion between "java.sql.Time" and "java.time.LocalTime" in either direction results in the loss of precision when based on the standard API (Time.valueOf(LocalTime) and Time.toLocalTime()). Everything is rounded to whole seconds.

I think our LocalTimeValueType is also affected by this problem.

Below is how I addressed it in Agrest. The use of "ZoneId.systemDefault()" in that implementation is somewhat questionable, but seems compatible with Time.toLocalTime() / Time.valueOf(LocalTime).

• https://github.com/agrestio/agrest/blob/master/agrest-engine/src/main/java/io/agrest/converter/jsonvalue/SqlTimeConverter.java
• https://github.com/agrestio/agrest/blob/master/agrest-engine/src/main/java/io/agrest/converter/valuestring/SqlTimeConverter.java

Interestingly, no other conversions (like Timestamp to LocalDateTime) are affected. Their JDK versions are working properly.