[CAY-2774] Overriding service ordering in DI List causes DIRuntimeException

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.2.RC1, 5.0-M1
• Fix Version/s: 5.0-M1
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 13/Nov/22 10:53
• Updated: 15/Nov/22 15:01
• Resolved: 15/Nov/22 15:01

Description

Per CAY-2772, I just tried changing the ordering of a filter in ListBuilder<DataChannelSyncFilter> by re-binding the filter with different relative order. Essentially:

contributeSyncFilters().insertBefore(CommitLogFilter.class, TransactionFilter.class);
contributeSyncFilters().addAfter(CommitLogFilter.class, TransactionFilter.class);

This results in a dependency cycle exception:

org.apache.cayenne.di.DIRuntimeException: Dependency cycle detected in DI container

	at org.apache.cayenne.di.spi.DIGraph.topSort(DIGraph.java:155)
	at org.apache.cayenne.di.spi.ListProvider.get(ListProvider.java:47)
	at org.apache.cayenne.di.spi.ListProvider.get(ListProvider.java:35)
	at org.apache.cayenne.di.spi.DefaultScopeProvider.get(DefaultScopeProvider.java:50)
	at org.apache.cayenne.di.spi.DefaultInjector.getInstance(DefaultInjector.java:139)
	at org.apache.cayenne.di.spi.FieldInjectingProvider.value(FieldInjectingProvider.java:103)

I think we can actually properly handle this case by removing the existing ordering, and rebinding with the new ordering.