[CAY-2660] BigDecimals that differ only in scale are treated as different values causing unneeded updates

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.2, 4.1.RC2, 4.2.M1
• Fix Version/s: 4.2.M2
• Assignee: Unassigned
• Reporter: Andrus Adamchik
• Created: 05/Jun/20 12:31
• Updated: 05/Feb/21 09:44
• Resolved: 05/Feb/21 09:44

Description

Given a column mapping of "DECIMAL(N, M)" to Java BigDecimal, the following code causes an update where it shouldn't (as there are no changes) :

// assuming the column is "DECIMAL(12, 6)"

BigDecimal bd = new BigDecimal("7890.1");

// save object
o.setValue(bd);
o.getObjectContext().commitChanges();

// refetch object - the result will be padded to DB scale - "7890.100000"
BigDecimalEntity o2 = ObjectSelect.query(BigDecimalEntity.class).selectFirst(runtime.newContext());

// set to the same value and commit
o2.setValue(bd);

// *** PROBLEM HERE - "UPDATE" SQL is generated, while logically it should have been a noop
o2.getObjectContext().commitChanges();

I have a PR with a fix based on using "compareTo" instead of "equals" for BigDecimals, but it will require some discussion...