[CAY-2650] Support using generated primary keys along with batch inserts

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.2.M1
• Component/s: Core Library
• Assignee: John Huss
• Reporter: John Huss
• Created: 12/Feb/20 22:18
• Updated: 13/May/20 13:11
• Resolved: 13/May/20 13:11

Description

Currently, using generated PKs explicitly prevents multiple inserts from using a batch-bind insert. This is unhelpful since switching to generated PKs could potentially cause a performance decrease for certain use cases because of the lack of batch insert functionality.

This is prohibited by the existing BatchAction:

if (runningAsBatch && !generatesKeys) {
	runAsBatch(connection, translator, observer);
} else {
	runAsIndividualQueries(connection, translator, observer, generatesKeys);
}

Having done very brief performance testing against PostgreSQL, the performance difference turns out to be minimal for a realistic production scenario, but even so, this is a restriction worth removing I think.

I have a pull request coming for this.

Issue Links

• links to: GitHub Pull Request #413