[CAY-2268] DI: Refactor ListBuilder API ambiguities for before() / after() bindings

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.B1
• Component/s: Core Library
• Labels: DI
• Assignee: Nikita Timofeev
• Reporter: Nikita Timofeev
• Created: 16/Mar/17 07:46
• Updated: 21/Mar/17 15:02
• Resolved: 21/Mar/17 15:02

Description

There are some problems and ambiguities with API for adding ordered dependencies:

1. you can call after() / before() without adding anything first, that will cause NPE
2. right order of calls is not clear: add().after() or after().add()

Suggested API modification:

1. remove UnorderedListBuilder, keep everything in ListBuilder
2. add methods with explicit before\after parameters:

       ListBuilder<T> addAfter(Class<? extends T> interfaceType, Class<? extends T> afterType);
   
       ListBuilder<T> addAfter(T value, Class<? extends T> afterType);
   
       ListBuilder<T> addAllAfter(Collection<T> values, Class<? extends T> afterType);
   
       ListBuilder<T> insertBefore(Class<? extends T> interfaceType, Class<? extends T> beforeType);
   
       ListBuilder<T> insertBefore(T value, Class<? extends T> beforeType);
   
       ListBuilder<T> insertAllBefore(Collection<T> values, Class<? extends T> beforeType);