[CAY-2256] Cannot Save/Insert an Object With null Flattened (complex) toOne Relationship

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.M4
• Fix Version/s: 4.0.B1
• Component/s: Core Library
• Labels: flattened null relationship toOne
• Assignee: Nikita Timofeev
• Reporter: Matt Watson
• Created: 06/Mar/17 19:17
• Updated: 10/Mar/17 07:29
• Resolved: 10/Mar/17 07:29

Description

When using a Flattened complex join for a toOne Relationship... if you do not set the relationship the validateForSave on CayenneDataObject incorrectly attaches a ValidationFailure saying that the relationship is required.

Prior to 4.0.M4 this worked correctly, but the commit fixing CAY-2146 introduced this issue. More directly the line of code holding the IF statement below was updated to check the db.Rels.size().

CayenneDataObject.java

if (dbRels.size() == 1 && relationship.isSourceIndependentFromTargetChange()) {
    continue;
}

While putting this code back makes the test for this issue pass, it obviously makes the test for CAY-2146 FAIL, so I'm not suggesting to put it back, but just pointing it out in case it helps better understand this issue.

(see attached breaking-test.patch)

Issue Links

• is related to: CAY-2146 Vertical inheritance: record still inserted into parent db table when child validation fails
• links to: GitHub Pull Request #175