[CAY-2101] DataContext.currentSnapshot() doesn't set snapshot entity name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.M3, 3.1.1
• Fix Version/s: 4.0.M4, 3.1.2
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 12/Aug/16 07:39
• Updated: 12/Aug/16 15:18
• Resolved: 12/Aug/16 15:18

Description

DataContext.currentSnapshot() fails to set created snapshot entity name. This causes confusion downstream. One obscure case that I was finally able to trace to this issue was related to inheritance:

• "currentSnapshot" was called for concrete subclass during new object commit.
• returned snapshot ended up in the shared cache
• later a RelationshipQuery for another object pointing to this one received the snapshot from cache.
• The result was the attempt to instantiate an abstract superclass instead of subclass

So we need to fix 'currentSnapshot' and maybe also add sanity checks to "objectsFromDataRows" to throw on invalid snapshots.