Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • Database integration
    • None

    Description

      Support for FirebirdSQL - http://www.firebirdsql.org

      Attachments

        1. tests_firebird.patch
          7 kB
          Miłosz Pigłas
        2. test_merge.patch
          0.5 kB
          Miłosz Pigłas
        3. test_ashwood.patch
          0.6 kB
          Miłosz Pigłas
        4. firebird1.patch
          24 kB
          Miłosz Pigłas

        Activity

          File firebird1.patch adds Firebird adapter files, binds it with cayenne and adds configuration for unit tests.

          File tests_firebird.patch changes few test cases to avoid platform specyfic errors

          kurhan Miłosz Pigłas added a comment - File firebird1.patch adds Firebird adapter files, binds it with cayenne and adds configuration for unit tests. File tests_firebird.patch changes few test cases to avoid platform specyfic errors

          Committed.

          In my tests with FireBird 2.5 on Linux, I got 10 errors [1]. Which IMO is a pretty decent score. BTW, here is a provisioning script that I am using with vagrant to setup FireBird on Ubuntu 12 VM - [2]

          [1] Tests in error:
          testAddAndDropColumnToDb(org.apache.cayenne.merge.MergerFactoryTest)
          testChangeVarcharSizeToDb(org.apache.cayenne.merge.MergerFactoryTest)
          testMultipleTokensToDb(org.apache.cayenne.merge.MergerFactoryTest)
          testAddTableToDb(org.apache.cayenne.merge.MergerFactoryTest)
          testAddForeignKeyWithTable(org.apache.cayenne.merge.MergerFactoryTest)
          testAddForeignKeyAfterTable(org.apache.cayenne.merge.MergerFactoryTest)
          test(org.apache.cayenne.merge.SetNotNullToDbTest)
          testMerging(org.apache.cayenne.util.EntityMergeSupportTest)
          testSortObjectsForEntityReflexiveWithFaults(org.apache.cayenne.ashwood.AshwoodEntitySorterTest)
          testSelectLongIn(org.apache.cayenne.query.SelectQueryTest)

          Tests run: 2179, Failures: 0, Errors: 10, Skipped: 0

          [2] #!/bin/bash

          apt-get -y install firebird2.5-super
          perl -i -ne 's/ENABLE_FIREBIRD_SERVER=no/ENABLE_FIREBIRD_SERVER=yes/; print' /etc/default/firebird2.5
          service firebird2.5-super start
          echo "create database '/tmp/cayenne.fdb' user 'SYSDBA' password 'masterkey';" | isql-fb

          andrus Andrus Adamchik added a comment - Committed. In my tests with FireBird 2.5 on Linux, I got 10 errors [1] . Which IMO is a pretty decent score. BTW, here is a provisioning script that I am using with vagrant to setup FireBird on Ubuntu 12 VM - [2] [1] Tests in error: testAddAndDropColumnToDb(org.apache.cayenne.merge.MergerFactoryTest) testChangeVarcharSizeToDb(org.apache.cayenne.merge.MergerFactoryTest) testMultipleTokensToDb(org.apache.cayenne.merge.MergerFactoryTest) testAddTableToDb(org.apache.cayenne.merge.MergerFactoryTest) testAddForeignKeyWithTable(org.apache.cayenne.merge.MergerFactoryTest) testAddForeignKeyAfterTable(org.apache.cayenne.merge.MergerFactoryTest) test(org.apache.cayenne.merge.SetNotNullToDbTest) testMerging(org.apache.cayenne.util.EntityMergeSupportTest) testSortObjectsForEntityReflexiveWithFaults(org.apache.cayenne.ashwood.AshwoodEntitySorterTest) testSelectLongIn(org.apache.cayenne.query.SelectQueryTest) Tests run: 2179, Failures: 0, Errors: 10, Skipped: 0 [2] #!/bin/bash apt-get -y install firebird2.5-super perl -i -ne 's/ENABLE_FIREBIRD_SERVER=no/ENABLE_FIREBIRD_SERVER=yes/; print' /etc/default/firebird2.5 service firebird2.5-super start echo "create database '/tmp/cayenne.fdb' user 'SYSDBA' password 'masterkey';" | isql-fb

          You are right. I probably missed them, because I was using newer version of surefire.

          Patches test_ashwood and test_merge fixes MergerFactoryTest and AshwoodEntitySorterTest.

          kurhan Miłosz Pigłas added a comment - You are right. I probably missed them, because I was using newer version of surefire. Patches test_ashwood and test_merge fixes MergerFactoryTest and AshwoodEntitySorterTest.

          Much better. After these 2 patches we only have this one failure:

          Tests in error:
          testSelectLongIn(org.apache.cayenne.query.SelectQueryTest)

          That was discussed already. Great! Committed.

          andrus Andrus Adamchik added a comment - Much better. After these 2 patches we only have this one failure: Tests in error: testSelectLongIn(org.apache.cayenne.query.SelectQueryTest) That was discussed already. Great! Committed.

          I also added CayenneModeler integration per r1493563... I guess ideally Modeler should automatically pick up new adapters based on the contents of SERVER_ADAPTER_DETECTORS_LIST in ServerModule. For now have to add it manually.

          andrus Andrus Adamchik added a comment - I also added CayenneModeler integration per r1493563... I guess ideally Modeler should automatically pick up new adapters based on the contents of SERVER_ADAPTER_DETECTORS_LIST in ServerModule. For now have to add it manually.

          Thank you for all your help .

          kurhan Miłosz Pigłas added a comment - Thank you for all your help .

          People

            Unassigned Unassigned
            kurhan Miłosz Pigłas
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: