[CAY-1813] Missing ObjEntity Attribute Validation with Duplicate DbEntity Columns

• Type: Improvement
• Status: Reopened
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: Undefined future, 3.0.3
• Component/s: Modeler
• Assignee: Michael Gentry
• Reporter: Michael Gentry
• Created: 23/Apr/13 17:13
• Updated: 03/Apr/15 10:19

Description

If you have two ObjEntity attributes mapped to the same DbEntity column, this should produce a validation warning.

Real world example (from <obj-entity> tag):

<obj-attribute name="addressFrom" type="java.lang.String" db-attribute-path="DRIVER_ID"/>
<obj-attribute name="driverId" type="java.math.BigInteger" db-attribute-path="DRIVER_ID"/>

In this example, addressFrom was mistakenly mapped to the DRIVER_ID column with no validation warning. DRIVER_ID is a foreign key.

At runtime, trying to fault to the driver using getDriver(), this SQL was produced:

SELECT ... WHERE t0.ID = ? [bind: 1->ID:'1'] (note the quotes)

The Cayenne runtime found the first mistakenly-mapped DRIVER_ID and used it, which happened to be a String, causing the SQL to be incorrectly produced and the fault to fail.

This was difficult to track down. A validation check to make sure the DB columns aren't mapped more than once would be helpful to eliminate errors.