[CAY-1803] Optimize Expression conversion to String and EJBQL

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.2.M1
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 15/Mar/13 14:06
• Updated: 18/Mar/13 19:31
• Resolved: 15/Mar/13 18:30

Description

Expression.toString() is pretty heavy:

@Override
public String toString()

{ StringWriter buffer = new StringWriter(); PrintWriter pw = new PrintWriter(buffer); encodeAsString(pw); pw.close(); buffer.flush(); return buffer.toString(); }

We didn't bother much about it, as it wasn't supposed to be called in runtime... Well it is sometimes:

SelectTranslator,java:

433 String labelPrefix = pathExp.toString().substring("db:".length());

And I am seeing this line occasionally in my app profiling reports. So we need to override "toString" at least for ASTObjPath and ASTDbPath with a lighter implementation