[CAY-1774] EhCacheQueryCache.get(QueryMetadata, QueryCacheEntryFactory) returns null if EhCache instance for group is not present

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1B1
• Fix Version/s: 3.1B2, 3.2.M1
• Component/s: Core Library
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 22/Nov/12 10:35
• Updated: 22/Nov/12 11:09
• Resolved: 22/Nov/12 11:09

Description

Here is a problematic piece of code:

public List get(QueryMetadata metadata, QueryCacheEntryFactory factory) {
String key = metadata.getCacheKey();
if (key == null)

{ return null; }

Ehcache cache = null;
Element result = null;
String[] groupNames = metadata.getCacheGroups();
if (groupNames != null && groupNames.length > 0) {

// SHOULD WE USE 'addCacheIfAbsent' here, as we already have a factory to populate object???
cache = cacheManager.getCache(groupNames[0]);
if (cache == null)

{ return null; }

....

Sure enough there is a workaround of declaring all cache groups as "caches" within ehcache.xml, so this issue may be about usability and consistency after all ('put' for instance uses 'addCacheIfAbsent', but not 'get' with factory).

Also maybe we can refactor calls to 'get' and 'put' within this method to avoid multiple cache lookups, when we already have a cache instance in place.