[CAY-1409] Pkgenerator is accessed needlessly for join tables with own database generated PK

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0RC2
• Fix Version/s: 3.0RC3
• Component/s: Core Library
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 28/Mar/10 19:09
• Updated: 28/Mar/10 19:53
• Resolved: 28/Mar/10 19:53

Description

Preconditions:
1. A join table that have its own non-propagated PK that is "database generated"
2. A flattened relationship between two entities over the join table above

On insert, PKGenerator for the join table is (incorrectly) accessed:

INFO: LOCK TABLES AUTO_PK_SUPPORT WRITE
Mar 28, 2010 9:58:16 PM org.apache.cayenne.access.QueryLogger logQuery
INFO: SELECT NEXT_ID FROM AUTO_PK_SUPPORT WHERE TABLE_NAME = 'GENERATED_JOIN'
Mar 28, 2010 9:58:16 PM org.apache.cayenne.access.QueryLogger logQuery
INFO: UPDATE AUTO_PK_SUPPORT SET NEXT_ID = NEXT_ID + 20 WHERE TABLE_NAME = 'GENERATED_JOIN' AND NEXT_ID = 200
Mar 28, 2010 9:58:16 PM org.apache.cayenne.access.QueryLogger logQuery
INFO: UNLOCK TABLES

Even though the store PK is (correctly) assigned based on the autoincrement value:

INFO: INSERT INTO GENERATED_JOIN (ID1, ID2) VALUES (?, ?)
Mar 28, 2010 9:58:16 PM org.apache.cayenne.access.QueryLogger logQueryParameters
INFO: [bind: 1->ID1:200, 2->ID2:200]

Should prevent uneeded PkGenerator call.