[CAY-1165] Stop unwinding runtime exceptions

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.0M5
• Fix Version/s: Undefined future
• Component/s: Core Library
• Assignee: Andrus Adamchik
• Reporter: Andrus Adamchik
• Created: 09/Jan/09 10:30
• Updated: 06/Jan/10 10:03

Description

The practice of unwinding Cayenne exceptions seemed like a good idea at the time. This would look like:

try

{ .... }

catch (Exception ex)

{ throw new CayenneException("Exception", Util.unwindException(ex)); }

And was supposed to trim Exception chain to just the underlying cause plus a Cayenne[Runtime]Exception wrapper. However in many cases intermediate places where Cayenne catches exception, wraps it and rethrows, provide additional forensics info helping to identify the cause. For instance FieldAccessor shows which field has failed:

try

{ field.set(object, newValue); }

catch (Throwable th)

{ throw new PropertyException( "Error writing field: " + field.getName(), this, object, th); }

So I think we should get rid of all calls to Util.unwindException(..) and rethrow it unchanged.