[CAUSEWAY-996] [WON'T FIX] Define component factories as Spring @Components

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: viewer-wicket-1.7.0
• Fix Version/s: 2.0.0-M4
• Component/s: Viewer Wicket
• Assignee: Andi Huber
• Reporter: Daniel Keir Haywood
• Created: 04/Jan/15 10:05
• Updated: 04/Oct/20 08:49
• Resolved: 04/Oct/20 08:49

Description

was previously:

Not possible to "replace" components in Wicket viewer (workaround is to use "add")

~~~~~

As per http://isis.markmail.org/thread/x3k2www3m2wfsgtv

To recreate:

• copy ReferencePanelFactory to ReferencePanelFactory2

in (subclass of) IsisWicketApplication, add:

    @com.google.inject.Singleton
    public static class MyComponentFactoryRegistrar extends ComponentFactoryRegistrarDefault {

        @Override
        public void addComponentFactories(ComponentFactoryList componentFactories) {
            super.addComponentFactories(componentFactories);
            componentFactories.replace(new ReferencePanelFactory2());
        }
    }

and

        final Module overrides = new AbstractModule() {
            @Override
            protected void configure() {
                 ...
                bind(ComponentFactoryRegistrar.class).
                    to(MyComponentFactoryRegistrar.class);
            }
        };

the issue is that "replace" ends up replacing all component factories of type ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace the one for ReferencePanelFactory.

The workaround is easy enough: call "add" (which puts new factory at beginning of list) rather than "replace".

Issue Links

• relates to: CAUSEWAY-2337 [WON'T FIX] FacetFactories to be managed by Spring