[CAUSEWAY-3734] Excel import slow

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: Ext Core Excel
• Labels: performance
• Assignee: Daniel Keir Haywood
• Reporter: ocs_wove
• Created: 07/May/24 11:13
• Updated: 08/May/24 08:55

Description

While importing an excel file for every cell that is read a property change event is fired and a command log entry is created. With large data sheets in Excel the performance is not good and an OutOfMemoryException may occur.

This can be changed by changing in _ExcelConverter class this line:

otoa.set(templateAdapter, valueAdapter, InteractionInitiatedBy.USER);

into:

otoa.set(templateAdapter, valueAdapter, InteractionInitiatedBy.PASS_THROUGH);

 

The PASS_THROUGH enum is documented as ment for e.g. serialisation.

Issue Links

• links to: GitHub Pull Request #2403