[CAUSEWAY-3610] AuditTrailEntry instances not correlated back to command if executed via CommandExecutorService (ie background commands)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-RC2
• Fix Version/s: 2.0.0-RC3
• Component/s: Core
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 26/Sep/23 20:39
• Updated: 02/Oct/23 20:32
• Resolved: 27/Sep/23 17:27

Description

The AuditTrailEntry#getInteractionId() is copied from InteractionService#currentInteractionId(), which is a different value than that of InteractionService#currentInteraction().getInteractionId() when the CommandExecutorService is in use.

This is because the latter delegates to Interaction#getCommand(), where the CommandExecutorService mutates the interactionId with that of the command being executed, whereas the former is unchanged with its own copy of the interactionId taken prior to this.

The fix I think is to eliminate the cache in the former so that InteractionService#currentInteractionId() returns the correct value (that of the interactionId of the command being executed).