[CAUSEWAY-3507] RepositoryService#allMatches should support JDOQL that has a 'result'

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-RC1
• Fix Version/s: 2.0.0-RC2
• Component/s: Persistence JDO
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 28/Jun/23 16:46
• Updated: 13/Jul/23 09:34
• Resolved: 03/Jul/23 07:34

Description

given this JDOQL:

SELECT DISTINCT this.paymentMethod FROM IncomingInvoice

it is not possible to submit using RepositoryService#allMatches(...)

 

compared to v1, the reason seems to be that we used to use JDOQuery#executeWithMap(), whereas now we use JDOQuery#executeList, and the latter has a check for whether there is a return phrase (ie "DISTINCT this.paymentMethod").

The fix, I think, is to call either JDOQuery#executeResultList  rather than JDOQuery#executeList if there is a result phrase.