[CAUSEWAY-3303] Redefine UserMemento#isSystemUser to instead take into account SudoService#accessAll role

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M9
• Fix Version/s: 2.0.0-RC1
• Component/s: Ext Sec Secman
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 08/Dec/22 10:50
• Updated: 08/Mar/23 17:20
• Resolved: 08/Mar/23 17:20

Description

We currently have two very similar notions that are meant to disable permission checking (typically for integration tests), `UserMemento#isSystemUser`, and separately the `SudoService#ACCESS_ALL` role, as set up by the `NoPermissionsCheck` junit 5 extension.

However, the `TenantedAuthorizationFacetDefault` is only aware of the former of these, via `UserService#isCurrentUserWithSystemPrivileges`, and because the UserMemento#isSystem is an equality check, the two mechanisms are incompatible.

Luckily, `TenantedAuthorizationFacetDefault` is the only usage of this API.  Therefore, the purpose of this improvement is to combine these two notions, and refactor names from (real) "system user" (aka root) to (effective) user (aka sudo).

Issue Links

• links to: GitHub Pull Request #1252