[CAUSEWAY-2754] Use @AliasFor to declare Spring's @Named from @DomainService(logicalTypeName)

• Type: New Feature
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M5
• Fix Version/s: 2.0.0-M6
• Component/s: Core
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 19/Jun/21 06:22
• Updated: 25/Aug/21 14:33
• Resolved: 01/Aug/21 15:18

Description

attempted this, using:

public @interface DomainService {

    // ...
    @AliasFor(annotation = Named.class, attribute = "value")
    String logicalTypeName() default "";

} 

however it results in:

Caused by: org.springframework.core.annotation.AnnotationConfigurationException: @AliasFor declaration on attribute 'logicalTypeName' in annotation [org.apache.isis.applib.annotation.DomainService] declares an alias for attribute 'value' in annotation [javax.inject.Named] which is not meta-present. 
at org.springframework.core.annotation.AnnotationTypeMapping.validateAllAliasesClaimed(AnnotationTypeMapping.java:372) 
at org.springframework.core.annotation.AnnotationTypeMapping.afterAllMappingsSet(AnnotationTypeMapping.java:359) 
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541) 
at org.springframework.core.annotation.AnnotationTypeMappings.<init>(AnnotationTypeMappings.java:69) 
at org.springframework.core.annotation.AnnotationTypeMappings.<init>(AnnotationTypeMappings.java:46) 
at org.springframework.core.annotation.AnnotationTypeMappings$Cache.createMappings(AnnotationTypeMappings.java:245) 
at java.base/java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:330) 

that means we need to add @Named to @DomainService

 

Issue Links

• links to: GitHub Pull Request #662