[CAUSEWAY-2749] [Duplicate] Convert IsisConverterLocator into a domain service and allow Wicket Converters to be substituted in.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 2.0.0-M5
• Fix Version/s: 2.0.0-M7
• Component/s: Core
• Assignee: Unassigned
• Reporter: Daniel Keir Haywood
• Created: 17/Jun/21 11:51
• Updated: 10/Dec/21 08:45
• Resolved: 10/Dec/21 08:45

Description

For example, if enter 'abc' into a BigDecimal' then the error message returned is effectively hardcoded because in IsisWicketApplication we just use Wicket's default ConverterLocator (fine tuned with a couple of extra types to convert).  That means we get:

We also have a bit of technical debt, because there is an IsisConverterLocator that doesn't implement Wicket's IConvertLocator, and is just called from one place, statically, to render an object as a string.

So we should perhaps:

• provide our own impl of IConveterLocator, probably subclassed from Wicket's
• make it a Spring Bean
• get rid of IsisConverterLocator (roll it into aforementioned IConverterLocator)
• decide on a way to allow new/replacement converters to be registered.

We might also want to look at the ValueTypeRegistry we have, just in case there's overlap.

 

 

Issue Links

• Is contained by: CAUSEWAY-2882 [Wicket Viewer] Support for generic Value-Type Conversion based on ValueSemantics