[CAUSEWAY-2706] JPA does not persist entities with application-defined primary keys

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-M5
• Fix Version/s: 2.0.0-M6
• Component/s: Persistence JPA
• Assignee: Andi Huber
• Reporter: Daniel Keir Haywood
• Created: 28/May/21 05:22
• Updated: 05/Jun/21 09:11
• Resolved: 30/May/21 06:23

Description

For example, secman's ApplicationTenancy cannot be persisted as currently implemented.

Reason (perhaps): there is logic in ManagedObjects.EntityUtil.getState() to infer the entity state of the object, and for such entities it returns the state as PERSISTABLE_DESTROYED rather than DETACHED, meaning that flush transaction is never called. 

To reproduce, simply attempt to create a new ApplicationTenancy. 

 

HERE'S THE CODE THAT SHOWS the entity is not reported as detached,so the transaction never flushed:

 

THE FIX MIGHT BE TO SIMPLY REMOVE THE HIGHLIGHTED, WHICH PERHAPS IS A PERFORMANCE OPTIMISATION?  (or,  it is only safe to do if the @Id also has @GeneratedValue, which application-defined primary keys do not, of course.