[CAUSEWAY-2192] Improve the mavendeps-testing, to avoid accidental junit 4 dependency

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-M3
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 28/Nov/19 10:14
• Updated: 12/Feb/20 21:59
• Resolved: 12/Feb/20 21:59

Description

At the moment the isis-mavendeps-testing defines transitive dependencies on both unittestsupport and integtestsupport.

 

unittestsupport defines the JMock rule stuff, which depends on junit 4: don't want to change this for now.

 

for integtestsupport, though, want to force upgrade to junit 5, which also means removing any accidental dependencies on junit:junit:4.x

 

The following dependency for integ tests works, but think it might be better to define two different mavendeps, one for unit testing and one for integ testing.

 

<dependency>
<groupId>org.apache.isis.mavendeps</groupId>
<artifactId>isis-mavendeps-testing</artifactId>
<type>pom</type>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.apache.isis.core</groupId>
<artifactId>isis-unittestsupport</artifactId>
</exclusion>
<exclusion>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
</exclusion>
</exclusions>
</dependency>