[CASSANDRASC-78] Fix token-ranges endpoint to handle gossip-info responses without 'status'

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.0
• Component/s: Rest API
• Labels: pull-request-available
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test

Source Control Link

https://github.com/apache/cassandra-sidecar/commit/b267c44e568f3d08a71eab9fc9634ae94c229369

Test and Documentation Plan

Validated fix in unit tests and in-jvm-dtests

• Assignee: Arjun Ashok
• Reporter: Arjun Ashok

Authors

Arjun Ashok

Reviewers

Dinesh Joshi, Francisco Guerrero, Yifan Cai

• Created: 19/Oct/23 18:52
• Updated: 25/Oct/23 00:59
• Resolved: 25/Oct/23 00:09

Description

This is a fix to look for the host status in ‘Status’ and ‘StatusWithPort’ attributes in GossipInfo response  to determine the ‘state’ of the node.

Currently, we only check for ‘status’ which can be missing from gossipInfo in some cases, which will result in a replacement node status to be reported as `Joining` instead of `Replacing`.

eg.

Found gossipInfoEntry={generation=1697736379, schema=6d6abc83-a600-35a4-8bbe-fe5edca6a63b, rack=rack1, heartbeat=119, releaseVersion=4.1.4-SNAPSHOT, hostId=00000000-0000-4000-8000-000000000006, nativeAddressAndPort=127.0.0.6:9042, load=76459.0, internalAddressAndPort=127.0.0.6:7012, sstableVersions=big-nb, tokens=<hidden>, dc=datacenter1, netVersion=12, statusWithPort=BOOT_REPLACE,127.0.0.5:7012}

Issue Links

• links to: GitHub Pull Request #73