[CASSANDRASC-105] RestoreSliceTask could be stuck due to missing exception handling

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.0
• Component/s: Rest API
• Labels: pull-request-available
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report

Source Control Link

https://github.com/apache/cassandra-sidecar/commit/9b56cdd11a25550f0628e99ba35650c44663eb19

Test and Documentation Plan

Unit tests

• Assignee: Saranya Krishnakumar
• Reporter: Yifan Cai

Authors

Saranya Krishnakumar

Reviewers

Francisco Guerrero, Yifan Cai, Yifan Cai

• Created: 14/Feb/24 21:28
• Updated: 18/Mar/24 23:50
• Resolved: 18/Mar/24 23:50

Description

In RestoreSliceTask, there are a few places could throw exceptions but missing exception handling in call-sites. As a result, the RetoreSliceTask never fulfill the promise, i.e. the task is stuck.
For example, downloadObjectIfAbsent could throw instead of returning a future, in such case, the task will never fail or complete.

Issue Links

• links to: GitHub Pull Request #107