[CASSANDRASC-104] Relocate Sidecar common classes in vertx-client-shaded

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.0
• Component/s: Configuration
• Labels: pull-request-available
• Change Category: Semantic
• Complexity: Low Hanging Fruit

Source Control Link

https://github.com/apache/cassandra-sidecar/commit/b5570109c19acaf91281fd7901041c0c2b1f3b6c

Test and Documentation Plan

No tests added to the patch

• Assignee: Francisco Guerrero
• Reporter: Francisco Guerrero

Authors

Francisco Guerrero

Reviewers

Yifan Cai

• Created: 13/Feb/24 05:12
• Updated: 14/Feb/24 17:02
• Resolved: 14/Feb/24 17:02

Description

It is desirable to relocate the common classes org.apache.cassandra.sidecar.common.* in the vertx-client-shaded subproject. The benefits are the following:

• Better isolation of the shared classes when loading them in downstream projects (i.e Analytics)
• Avoids having two classes loaded in the same classpath, but with different internal definition (for example when annotations are relocated but the class itself is not)

Issue Links

• links to: GitHub Pull Request #100